Bug 55089

Summary: [chromium] Move media-file.js and video-test.js back to media/ for UILayoutTests
Product: WebKit Reporter: Victoria Kirst <vrk>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, annacc, commit-queue, dpranke, eric, jamesr, mihaip, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Mac OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch mihaip: review+, commit-queue: commit‑queue-

Description Victoria Kirst 2011-02-23 15:03:28 PST
[chromium] Move media-file.js and video-test.js back to media/ for UILayoutTests
Comment 1 Victoria Kirst 2011-02-23 15:08:50 PST
Created attachment 83554 [details]
Patch
Comment 2 Victoria Kirst 2011-02-23 15:26:32 PST
Created attachment 83562 [details]
Patch
Comment 3 Victoria Kirst 2011-02-23 15:37:04 PST
Moving media-file.js and video-test.js to http/tests/media/ caused Chromium's MediaUILayoutTests to fail (http://crbug.com/73287), so I moved them back to the media/ folder.

In order for the http tests to access these files, I added an alias to the media/ folder in the scripts that configure the httpd server.
Comment 4 WebKit Commit Bot 2011-02-24 10:38:28 PST
Comment on attachment 83562 [details]
Patch

Rejecting attachment 83562 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'bu..." exit_code: 2

Last 500 characters of output:

java/lc3/JSUndefined ..........
java/lc3/JavaArray ....
java/lc3/JavaClass ....
java/lc3/JavaObject .....................................
java/lc3/StringMethods .
java/lc3/forin .
java/lc3/instanceof .
loader ..
mathml .......
mathml/presentation ..................
media .
media/adopt-node-crash.html -> failed

Exiting early after 1 failures. 13006 tests run.
295.39s total testing time

13005 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
9 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/7984514
Comment 5 Mihai Parparita 2011-02-24 10:59:00 PST
I forgot that patches that move files can't be landed through the commit queue (see bug 49154). Will land this by hand.
Comment 6 Mihai Parparita 2011-02-24 11:43:05 PST
Committed r79598: <http://trac.webkit.org/changeset/79598>
Comment 7 Victoria Kirst 2011-02-24 12:14:01 PST
Thanks for landing, Mihai!
Comment 8 James Robinson 2011-02-24 14:38:28 PST
Reverted r79598 for reason:

Appears to be causing trouble with httpd on windows

Committed r79623: <http://trac.webkit.org/changeset/79623>
Comment 9 Mihai Parparita 2011-02-24 14:43:57 PST
(In reply to comment #8)
> Reverted r79598 for reason:
> 
> Appears to be causing trouble with httpd on windows
> 
> Committed r79623: <http://trac.webkit.org/changeset/79623>

Based on http://www.cyberciti.biz/tips/configure-lighttpd-alias-mod_alias.html it looks like subsequent alias.url lines need to use += in the lighthttpd config.
Comment 10 Mihai Parparita 2011-02-24 14:46:04 PST
(In reply to comment #9)
> Based on http://www.cyberciti.biz/tips/configure-lighttpd-alias-mod_alias.html it looks like subsequent alias.url lines need to use += in the lighthttpd config.

The logs show this too (from http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win/builds/2045/steps/webkit_tests/logs/stdio)

Duplicate config variable in conditional 0 global: alias.url
2011-02-24 14:19:12: (configfile.c.855) source: e:\b\build\slave\Webkit_Win\build\src\webkit\Release\..\../../layout-test-results\lighttpd.conf line: 105 pos: 1 parser failed somehow near here: (EOL)
Comment 11 Mihai Parparita 2011-02-24 15:10:56 PST
Committed r79630: <http://trac.webkit.org/changeset/79630>
Comment 12 WebKit Review Bot 2011-02-24 15:59:45 PST
http://trac.webkit.org/changeset/79598 might have broken GTK Linux 32-bit Release
Comment 13 WebKit Review Bot 2011-02-24 16:07:39 PST
http://trac.webkit.org/changeset/79623 might have broken GTK Linux 64-bit Debug