Bug 55030

Summary:

[jsc] Add more ASSERTs to JSGlobalData.cpp

Product:

WebKit

Reporter:

Harald Fernengel <harry>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Enhancement

CC:

barraclough, commit-queue, eric, ggaren

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	commit-queue: commit-queue-

Harald Fernengel

Reported 2011-02-23 03:23:18 PST

Add sanity checks when storing the global VTables. When linking statically, some aggressive compilers might optimize out the vtable from JSArray and friends if it can statically resolve all function calls. In this case, the assumption that the first data member in the class points to the VTable is wrong. To catch those cases early on, a few ASSERTs were added.

Attachments
the patch (3.68 KB, patch) 2011-02-23 03:24 PST, Harald Fernengel	commit-queue: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Harald Fernengel

Comment 1 2011-02-23 03:24:39 PST

Created attachment 83464 [details] the patch

Geoffrey Garen

Comment 2 2011-02-24 12:18:31 PST

Comment on attachment 83464 [details] the patch r=me

Eric Seidel (no email)

Comment 3 2011-02-24 12:19:24 PST

Comment on attachment 83464 [details] the patch Looks like this patch does not apply. Since I don't think Harald is a committer, marking cq+ (but I expect it will fail).

WebKit Commit Bot

Comment 4 2011-02-24 12:27:27 PST

Comment on attachment 83464 [details] the patch Rejecting attachment 83464 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'ap..." exit_code: 2 Last 500 characters of output: svn-apply', u'--reviewer', u'Geoffrey Garen', u'--force']" exit_code: 1 Parsed 2 diffs from patch file(s). patching file Source/JavaScriptCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/JavaScriptCore/runtime/JSGlobalData.cpp Hunk #1 FAILED at 84. 1 out of 1 hunk FAILED -- saving rejects to file Source/JavaScriptCore/runtime/JSGlobalData.cpp.rej Failed to run "[u'/Projects/CommitQueue/Tools/Scripts/svn-apply', u'--reviewer', u'Geoffrey Garen', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/7986549

Darin Adler

Comment 5 2011-06-18 12:30:16 PDT

Comment on attachment 83464 [details] the patch Need a new vresion of this patch that applies.

Gavin Barraclough

Comment 6 2012-03-12 14:09:42 PDT

I think this bug is now redundant. Not a bad idea at the time, but JS objects no longer have vptrs!

Note You need to log in before you can comment on or make changes to this bug.