| Summary: | nrwt: --platform chromium-gpu doesn't work with --worker-model=processes | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dirk Pranke <dpranke> | ||||||
| Component: | New Bugs | Assignee: | Dirk Pranke <dpranke> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | jamesr, mihaip, ojan, tony | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Other | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
|
Description
Dirk Pranke
2011-02-22 17:07:57 PST
Created attachment 83417 [details]
Patch
Note that there's no unit tests for this ... I have a bunch of patches pending that will revamp how we do versioning and clean up this code, so writing unit tests specifically for this patch will be wasted effort. I tested it by hand on the Mac and it should be fine. Comment on attachment 83417 [details]
Patch
R=me
Created attachment 83420 [details]
fix baseline_path() to point to the unversioned directory, add tests
so much for thinking testing wasn't worth it ... the first patch didn't work right. The second one adds tests :). Comment on attachment 83420 [details]
fix baseline_path() to point to the unversioned directory, add tests
Ahoy!
Committed r79380: <http://trac.webkit.org/changeset/79380> |