Bug 55009

Summary: nrwt: --platform chromium-gpu doesn't work with --worker-model=processes
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr, mihaip, ojan, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
fix baseline_path() to point to the unversioned directory, add tests jamesr: review+

Dirk Pranke
Reported 2011-02-22 17:07:57 PST
nrwt: --platform chromium-gpu doesn't work with --worker-model=processes
Attachments
Patch (1.64 KB, patch)
2011-02-22 17:10 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
fix baseline_path() to point to the unversioned directory, add tests (5.36 KB, patch)
2011-02-22 17:37 PST, Dirk Pranke 		jamesr: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2011-02-22 17:10:08 PST
Created attachment 83417 [details] Patch
Dirk Pranke
Comment 2 2011-02-22 17:11:54 PST
Note that there's no unit tests for this ... I have a bunch of patches pending that will revamp how we do versioning and clean up this code, so writing unit tests specifically for this patch will be wasted effort. I tested it by hand on the Mac and it should be fine.
James Robinson
Comment 3 2011-02-22 17:12:20 PST
Comment on attachment 83417 [details] Patch R=me
Dirk Pranke
Comment 4 2011-02-22 17:37:06 PST
Created attachment 83420 [details] fix baseline_path() to point to the unversioned directory, add tests
Dirk Pranke
Comment 5 2011-02-22 17:37:36 PST
so much for thinking testing wasn't worth it ... the first patch didn't work right. The second one adds tests :).
James Robinson
Comment 6 2011-02-22 17:38:15 PST
Comment on attachment 83420 [details] fix baseline_path() to point to the unversioned directory, add tests Ahoy!
Dirk Pranke
Comment 7 2011-02-22 18:09:30 PST
Committed r79380: <http://trac.webkit.org/changeset/79380>
Note You need to log in before you can comment on or make changes to this bug.