Bug 54994 – media test failures on SNOWLEOPARD (needs rebaseline)

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Anna Cavender]

The following tests need rebaseline under Snowleopard:

BUGWK54322 MAC SNOWLEOPARD : fast/media/mq-transform-02.html = IMAGE+TEXT 
BUGWK54322 MAC SNOWLEOPARD : fast/media/mq-transform-03.html = IMAGE+TEXT 

BUGWK54322 MAC SNOWLEOPARD : media/audio-controls-rendering.html = TEXT 
BUGWK54322 MAC SNOWLEOPARD : media/video-aspect-ratio.html = IMAGE 
BUGWK54322 MAC SNOWLEOPARD : media/video-empty-source.html = TEXT 
BUGWK54322 MAC SNOWLEOPARD : media/video-no-audio.html = TEXT 
BUGWK54322 MAC SNOWLEOPARD : media/video-volume-slider.html = TEXT 
BUGWK54322 MAC SNOWLEOPARD : media/video-zoom.html = IMAGE

[Anna Cavender]

Created attachment 83380 [details]
Patch

[Anna Cavender]

Created attachment 83481 [details]
Patch

[Anna Cavender]

old patch wouldn't apply.  trying with updated files.

[WebKit Commit Bot]

Comment on attachment 83481 [details]
Patch

Rejecting attachment 83481 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'build-..." exit_code: 2

Last 500 characters of output:
................
fast/loader .....................................................................................................
fast/loader/stateobjects ......................
fast/loading .
fast/media ...................................................................
fast/media/mq-transform-02.html -> failed

Exiting early after 1 failures. 9901 tests run.
240.95s total testing time

9900 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
6 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/7980153

[Anna Cavender]

Created attachment 83484 [details]
Patch

[Anna Cavender]

I'm not sure why the fast/media tests aren't passing, so I added those lines back into test_expections.txt to see what happens.

[Simon Fraser (smfr)]

Chromium doesn't compile with accelerated compositing enabled, so its results for mq-transform-02.html and mq-transform-03.html will differ from Safari on Mac.

[Anna Cavender]

Created attachment 83564 [details]
Patch

[Anna Cavender]

Quite a few more media/ tests needing rebaselines from when I first posted this bug, so I added those.

I put new baselines in chromium-mac/ and moved any existing Leopard ones to chromium-mac-leopard/.

Also, please note, fixes for the two fast/media tests:

BUGWK54322 MAC SNOWLEOPARD : fast/media/mq-transform-02.html = IMAGE+TEXT 
BUGWK54322 MAC SNOWLEOPARD : fast/media/mq-transform-03.html = IMAGE+TEXT

are not included as they are actually for CSS media type selector tests and were mistakenly included with media/ bugs.

Thanks!

[Eric Seidel (no email)]

The commit-queue can't land when the SL tests fail.  So it's unlikely that it will be able to land this.  There is a chance it will pick it up if it's early enough in the queue and successfully land it, but I wouldn't count on it.

[Eric Seidel (no email)]

Oh, this is chromium-only.  Then the cq can land it just fine.  SInce it uses the Apple Mac build.

[Anna Cavender]

Eric, can you see a reason why this patch seems stuck (not landing)?  I'm not getting any errors, but it's not getting picked up either ...

[Eric Seidel (no email)]

The SL bot was red all day yesterday.  The 6 commit-queue instances just can't land anything while the SL tests are red.  They're landing since 2am last night (when Ryosuke finally made the tree green).

[Eric Seidel (no email)]

(I should clarify: ryosuke was cleaning up someone elses mess, and the tree went red shortly after it went green which is why they didn't all land over night.  it's back green now and things are landing again.)

[Eric Seidel (no email)]

The queue lands upwards of 12 patches an hour when the tree is green. :)  Eventually we'll teach the commit-queue how to land when the tree is red, but for now it's very conservative and will wait until it can see a 100% pass on its machine before landing.

[Anna Cavender]

OK, thanks.  I see it going through the process now :)

[WebKit Commit Bot]

Comment on attachment 83564 [details]
Patch

Clearing flags on attachment: 83564

Committed r79603: <http://trac.webkit.org/changeset/79603>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.