Summary: | Page reload does not send any cache control headers | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nicolas Sandri <nicolas.sandri> | ||||||||||||
Component: | Page Loading | Assignee: | Alexey Proskuryakov <ap> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Major | CC: | ap | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 420+ | ||||||||||||||
Hardware: | Mac | ||||||||||||||
OS: | OS X 10.4 | ||||||||||||||
URL: | http://www.apple.com | ||||||||||||||
Attachments: |
|
Description
Nicolas Sandri
2005-10-25 09:53:08 PDT
Created attachment 4474 [details]
Safari load headers dump
Created attachment 4475 [details]
Safari reload headers dump
Created attachment 4476 [details]
Firefox load headers dump
Created attachment 4477 [details]
Firefox reload headers dump
Reassigning to webkit-unassigned, to make sure more people see this. This is related to bug 7414 (shift-reload functionality). Created attachment 8891 [details] proposed fix This fixes both manual reload and window.location.reload; not sure if there are other ways to cause reload that should send cache control headers (window.location.assign to the same URL doesn't do that in Firefox). Unfortunately, there doesn't seem to be a way to send If-Modified-Since together with max-age=0 (in other words, to validate freshness) with NSURLRequest, rdar://4590785. This doesn't affect correctness, but wastes bandwidth. The TransferJob-related code in WebCore::Frame seemed to be unused, other than for passing response HTTP headers. Comment on attachment 8891 [details]
proposed fix
r=me
I'm not sure about that FIXME in loadRequest: -- seems a little cryptic to me. It's fine to add a FIXME, but I'd like it to be more specific if possible.
Can the include of TransferJob.h be removed from Frame.cpp?
Committed revision 14920. (In reply to comment #8) > I'm not sure about that FIXME in loadRequest: -- seems a little cryptic to me. > It's fine to add a FIXME, but I'd like it to be more specific if possible. Changed the wording and also the meaning. There's probably nothing else needed to reset, but doing this in loadRequest: looks a bit hackish to me. > Can the include of TransferJob.h be removed from Frame.cpp? My patch was already removing it - am I missing something? |