Bug 54966

Summary: media/audio-repaint.html and media/media-document-audio-repaint.html failing on Windows since they were added
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, jer.noble, rniwa
Priority: P2 Keywords: InRadar, LayoutTestFailure, PlatformOnly
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
URL: http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r79318%20(9629)/results.html
Attachments:
Description Flags
Actual pixel results from audio-repaint.html
none
Expected pixel results from audio-repaint.html none

Adam Roben (:aroben)
Reported 2011-02-22 09:10:17 PST
media/audio-repaint.html and media/media-document-audio-repaint.html have been failing on Windows since they were added in r79318. See the URL for an example.
Attachments
Actual pixel results from audio-repaint.html (26.62 KB, image/png)
2011-02-22 09:11 PST, Adam Roben (:aroben) 		no flags
Details
Expected pixel results from audio-repaint.html (34.48 KB, image/png)
2011-02-22 09:11 PST, Adam Roben (:aroben) 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2011-02-22 09:11:09 PST
Created attachment 83329 [details] Actual pixel results from audio-repaint.html
Adam Roben (:aroben)
Comment 2 2011-02-22 09:11:27 PST
Created attachment 83330 [details] Expected pixel results from audio-repaint.html
Adam Roben (:aroben)
Comment 3 2011-02-22 09:12:01 PST
From IRC: <jernoble> aroben: it looks like it's attempting to draw the new-style controls, but using the old mediaControls.css rules. <jernoble> aroben: if you run your build results against safari (instead of drt) does everything look normal? <jernoble> aroben: i.e. could this be a DRT bug? <aroben> jernoble: yes <aroben> jernoble: my guess is this has to do with DRT setting the "use Mac-style controls" preference
Adam Roben (:aroben)
Comment 4 2011-02-22 09:17:08 PST
Expected failure results landed in r79328.
Adam Roben (:aroben)
Comment 5 2011-02-22 09:17:39 PST
<rdar://problem/9036342>
Ryosuke Niwa
Comment 6 2011-02-22 20:34:16 PST
(In reply to comment #4) > Expected failure results landed in r79328. I don't think these expected results are correct. Tests are failing both on Windows XP and Windows 7 bots.
Ryosuke Niwa
Comment 7 2011-02-22 20:45:59 PST
Committed r79392: <http://trac.webkit.org/changeset/79392>
Ryosuke Niwa
Comment 8 2011-02-22 21:49:59 PST
Committed r79400: <http://trac.webkit.org/changeset/79400>
Adam Roben (:aroben)
Comment 9 2011-02-23 08:03:42 PST
(In reply to comment #6) > (In reply to comment #4) > > Expected failure results landed in r79328. > > I don't think these expected results are correct. Tests are failing both on Windows XP and Windows 7 bots. The tests were changed in r79359. Thanks for updating the Windows results!
Note You need to log in before you can comment on or make changes to this bug.