Bug 54964 – [Qt] editing/deleting/5408255.html fails

• Component: HTML Editing
• Status: RESOLVED FIXED

[Chang Shu]

This seems to be a regression. The following is the results from qt linux buildbot.

--- /home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/layout-test-results/editing/deleting/5408255-expected.txt	2011-02-22 07:29:01.274281593 -0800
+++ /home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/layout-test-results/editing/deleting/5408255-actual.txt	2011-02-22 07:29:01.274281593 -0800
@@ -1,5 +1,4 @@
-ALERT: 22
-ALERT: 98
+CONSOLE MESSAGE: line 16: TypeError: 'null' is not an object (evaluating 'deleteButton.offsetParent')
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600
 layer at (0,0) size 800x600
@@ -10,5 +9,14 @@
           text run at (0,0) width 742: "This tests for a bug where the delete button wouldn't work because it had -webkit-user-select:none instead of -"
           text run at (0,21) width 177: "webkit-user-select:ignore. "
           text run at (177,21) width 478: "The list should be removed, the editable region below should be empty."
-      RenderBlock {DIV} at (0,58) size 784x53
-caret: position 0 of child 3 {DIV} of body
+      RenderBlock {DIV} at (0,58) size 784x106
+        RenderBlock {UL} at (16,32) size 752x42
+          RenderListItem {LI} at (40,0) size 712x21
+            RenderListMarker at (-18,0) size 7x21: bullet
+            RenderText {#text} at (0,0) size 8x21
+              text run at (0,0) width 8: "1"
+          RenderListItem {LI} at (40,21) size 712x21
+            RenderListMarker at (-18,0) size 7x21: bullet
+            RenderText {#text} at (0,0) size 8x21
+              text run at (0,0) width 8: "2"
+caret: position 0 of child 0 {#text} of child 1 {LI} of child 1 {UL} of child 3 {DIV} of body

[Chang Shu]

Created attachment 83388 [details]
fix patch

[Csaba Osztrogonác]

Comment on attachment 83388 [details]
fix patch

LGTM, r=me

[Chang Shu]

Comment on attachment 83388 [details]
fix patch

Clearing flags on attachment: 83388

Committed r79377: <http://trac.webkit.org/changeset/79377>

[Chang Shu]

All reviewed patches have been landed.  Closing bug.