Bug 54955
| Summary: | Theoretical resource memory leaks in AnimationBase.cpp | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | sangeetha.sugavanam |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | ap, dino, simon.fraser |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
sangeetha.sugavanam
In method ensurePropertyMap() in AnimationBase.cpp, memory is allocated for a Vector of type PropertyWrapperBase. Unfortunately, memory is never deallocated for this. A suggestion in the code says to use a refptr and toss it once we are done using the Vector. Unfortunately, this function is being called by many other methods and because of that destroying using in a refptr in the function itself may lead to crashes. This bug needs to be further investigated.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
What's the observable effect of this? There is a FIXME in the code, but it doesn't explain why not destroying the wrappers in a problem at all.
Simon Fraser (smfr)
This would only count as a leak if you wanted to unload the WebCore library and expect all associated memory to go away. I don't believe that WebCore supports being unloaded on any platform.
Simon Fraser (smfr)
We have many of these in WebCore. We're not going to change this strategy any time soon.