Bug 54901

Summary:

Use ASSERT_JIT_OFFSET in JITPropertyAccess32_64.cpp

Product:

WebKit

Reporter:

Xan Lopez <xan.lopez>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
assertjitoffset.diff	none

Xan Lopez

Reported 2011-02-21 12:43:28 PST

It's already used in JITPropertyAcess.cpp, and it's useful because it gives a message with the difference between the actual and the expected offset in case of failure.

Attachments
assertjitoffset.diff (7.50 KB, patch) 2011-02-21 12:45 PST, Xan Lopez	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Xan Lopez

Comment 1 2011-02-21 12:45:40 PST

Created attachment 83204 [details] assertjitoffset.diff

Martin Robinson

Comment 2 2011-02-21 13:05:04 PST

Comment on attachment 83204 [details] assertjitoffset.diff View in context: https://bugs.webkit.org/attachment.cgi?id=83204&action=review > Source/JavaScriptCore/jit/JITPropertyAccess32_64.cpp:522 > void JIT::emitSlow_op_put_by_id(Instruction* currentInstruction, Vector<SlowCaseEntry>::iterator& iter) > -- > 1.7.3.4 I guess this was an accident?

Gavin Barraclough

Comment 3 2011-02-21 13:07:18 PST

Comment on attachment 83204 [details] assertjitoffset.diff Excellent, thank you! - but please also change the case in JITCAll32_64.cpp, in compileOpCall.

Xan Lopez

Comment 4 2011-02-21 13:15:35 PST

Comment on attachment 83204 [details] assertjitoffset.diff Landed as r79247, also changing JITCall32_64.cpp

Xan Lopez

Comment 5 2011-02-21 13:15:50 PST

Closing.

Note You need to log in before you can comment on or make changes to this bug.