Bug 54891

Summary:

Web Inspector: make DOM storage and Database agents have the same lifetime as InspectorAgent

Product:

WebKit

Reporter:

Yury Semikhatsky <yurys>

Component:

Web Inspector (Deprecated)

Assignee:

Yury Semikhatsky <yurys>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

54112

Attachments:

Description	Flags
Patch	pfeldman: review+

Yury Semikhatsky

Reported 2011-02-21 10:43:59 PST

Web Inspector: make DOM storage and Database agents have the same lifetime as InspectorAgent. InspectorInstrumentation should use ActiveAgents structure to access them.

Attachments
Patch (24.80 KB, patch) 2011-02-21 10:46 PST, Yury Semikhatsky	pfeldman: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Yury Semikhatsky

Comment 1 2011-02-21 10:46:38 PST

Created attachment 83189 [details] Patch

Pavel Feldman

Comment 2 2011-02-21 10:55:09 PST

Comment on attachment 83189 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=83189&action=review > Source/WebCore/inspector/InspectorAgent.cpp:65 > #include "InspectorDatabaseResource.h" nuke this too? > Source/WebCore/inspector/InspectorAgent.cpp:343 > +#if ENABLE(DOM_STORAGE) Move them below the base agents? > Source/WebCore/inspector/InspectorAgent.cpp:346 > +#if ENABLE(DATABASE) This goes first.

Yury Semikhatsky

Comment 3 2011-02-22 01:34:58 PST

Committed r79303: <http://trac.webkit.org/changeset/79303>

Note You need to log in before you can comment on or make changes to this bug.