Bug 54889 – IndexedDB: Move some SQL code into IDBBackingStore

• Component: New Bugs
• Status: RESOLVED FIXED

[Hans Wennborg]

IndexedDB: Move some SQL code into IDBBackingStore

[Hans Wennborg]

Created attachment 83176 [details]
Patch

[Hans Wennborg]

Note: this patch is based on https://bugs.webkit.org/show_bug.cgi?id=54864, so it will not apply until that has landed. I expect the ews bots to fail.

I figured it might be a good idea to get it reviewed early, though.

It's a big patch, but most of it is just code being moved around. The main thing for a reviewer to look at would be the function names and signatures, I think.

[Hans Wennborg]

Created attachment 83309 [details]
Patch

[Jeremy Orlow]

Comment on attachment 83309 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=83309&action=review

r=me

> Source/WebCore/storage/IDBBackingStore.cpp:465
> +double IDBBackingStore::autoIncrementNumber(int64_t objectStoreId)

nextAUtoIncrementNumber maybe?

> Source/WebCore/storage/IDBBackingStore.h:63
> +    void getIndexes(int64_t objectStoreId, Vector<int64_t>& foundIds, Vector<String>& foundNames, Vector<String>& foundKeyPaths, Vector<bool>& foundUniqueFlags);

maybe split out get/create/delete index like you did for object store?

maybe split out all the calls for puts and make it clear you need to manually call all applicable?

[Hans Wennborg]

(In reply to comment #4)
> (From update of attachment 83309 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=83309&action=review
> 
> r=me
> 
> > Source/WebCore/storage/IDBBackingStore.cpp:465
> > +double IDBBackingStore::autoIncrementNumber(int64_t objectStoreId)
> 
> nextAUtoIncrementNumber maybe?
Yes, that's better. Done.

> 
> > Source/WebCore/storage/IDBBackingStore.h:63
> > +    void getIndexes(int64_t objectStoreId, Vector<int64_t>& foundIds, Vector<String>& foundNames, Vector<String>& foundKeyPaths, Vector<bool>& foundUniqueFlags);
> 
> maybe split out get/create/delete index like you did for object store?
Done.

> 
> maybe split out all the calls for puts and make it clear you need to manually call all applicable?
I've grouped the index and the object store stuff together, respectively. I think that makes more sense, but this is easy to change later if we want to.

[Hans Wennborg]

Committed r79445: <http://trac.webkit.org/changeset/79445>