| Summary: | REGRESSION(r79157): plugins/get-url-with-javascript-destroying-plugin.html make the next test crash | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||||||||
| Component: | Plug-ins | Assignee: | Nobody <webkit-unassigned> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Critical | CC: | alex, andersca, aroben, gustavo, kbalazs, mjs, mrobinson, xan.lopez | ||||||||||
| Priority: | P1 | Keywords: | Qt, QtTriaged | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Bug Depends on: | 54884 | ||||||||||||
| Bug Blocks: | 54837 | ||||||||||||
| Attachments: |
|
||||||||||||
I made buildbot happy: http://trac.webkit.org/changeset/79202 But it doesn't mean that we don't need to fix this bug ... It causes crash on GTK too. plugins/get-url-with-javascript-destroying-plugin.html introduced in r79157 and make the next test crash. One more attempt to make Qt buildbot happy: http://trac.webkit.org/changeset/79207 Created attachment 83156 [details]
Proposed patch
This patch fixes the issue for GTK, ossy is this enough for Qt?
(In reply to comment #5) > Created an attachment (id=83156) [details] > Proposed patch > > This patch fixes the issue for GTK, ossy is this enough for Qt? Unfortunately QtWebKit still crashes with this patch. (In reply to comment #6) > (In reply to comment #5) > > Created an attachment (id=83156) [details] [details] > > Proposed patch > > > > This patch fixes the issue for GTK, ossy is this enough for Qt? > > Unfortunately QtWebKit still crashes with this patch. For the crash log it seems it does not find the plugin, probably we have to add the source file to the make file? Created attachment 83162 [details]
GDB backtrace in debug mode (on Qt)
$ Tools/Scripts/run-webkit-tests --verbose --debug plugins/get-url-with-javascript-destroying-plugin.html plugins/get-user-agent-with-null-npp-from-npp-new.html
(In reply to comment #7) > For the crash log it seems it does not find the plugin, probably we have to add the source file to the make file? r79157 added Tests/GetURLWithJavaScriptURLDestroyingPlugin.cpp to the project: http://trac.webkit.org/changeset/79157/trunk/Tools/DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro aroben fixed the issue apparently. *** This bug has been marked as a duplicate of bug 54884 *** Whoops, sorry for not noticing this bug before filing bug 54884. And it still fails in GTK :), we need to add the file to the makefile. I'm going to reopen, add a dependency on the other bug and update the patch. Unskip test for Qt: http://trac.webkit.org/changeset/79235 Created attachment 83191 [details]
Proposed patch
Comment on attachment 83191 [details]
Proposed patch
LGTM, r=me.
Landed http://trac.webkit.org/changeset/79237 Hrm, not sure what EWS tested. |
Created attachment 83141 [details] crash log crash log: <attached>