Bug 54863

Summary: REGRESSION(r79157): plugins/get-url-with-javascript-destroying-plugin.html make the next test crash
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Plug-insAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Critical CC: alex, andersca, aroben, gustavo, kbalazs, mjs, mrobinson, xan.lopez
Priority: P1 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 54884    
Bug Blocks: 54837    
Attachments:
Description Flags
crash log
none
Proposed patch
none
GDB backtrace in debug mode (on Qt)
none
Proposed patch ossy: review+

Csaba Osztrogonác
Reported 2011-02-21 02:25:07 PST
Created attachment 83141 [details] crash log crash log: <attached>
Attachments
crash log (6.10 KB, text/plain)
2011-02-21 02:25 PST, Csaba Osztrogonác 		no flags
Details
Proposed patch (2.46 KB, patch)
2011-02-21 06:11 PST, Alejandro G. Castro 		no flags
DetailsFormatted DiffDiff
GDB backtrace in debug mode (on Qt) (4.08 KB, text/plain)
2011-02-21 07:11 PST, Csaba Osztrogonác 		no flags
Details
Proposed patch (1.31 KB, patch)
2011-02-21 10:56 PST, Alejandro G. Castro 		ossy: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2011-02-21 02:43:16 PST
I made buildbot happy: http://trac.webkit.org/changeset/79202 But it doesn't mean that we don't need to fix this bug ...
Csaba Osztrogonác
Comment 2 2011-02-21 03:11:32 PST
It causes crash on GTK too.
Csaba Osztrogonác
Comment 3 2011-02-21 03:16:35 PST
plugins/get-url-with-javascript-destroying-plugin.html introduced in r79157 and make the next test crash.
Csaba Osztrogonác
Comment 4 2011-02-21 03:27:58 PST
One more attempt to make Qt buildbot happy: http://trac.webkit.org/changeset/79207
Alejandro G. Castro
Comment 5 2011-02-21 06:11:15 PST
Created attachment 83156 [details] Proposed patch This patch fixes the issue for GTK, ossy is this enough for Qt?
Csaba Osztrogonác
Comment 6 2011-02-21 06:21:04 PST
(In reply to comment #5) > Created an attachment (id=83156) [details] > Proposed patch > > This patch fixes the issue for GTK, ossy is this enough for Qt? Unfortunately QtWebKit still crashes with this patch.
Alejandro G. Castro
Comment 7 2011-02-21 06:27:52 PST
(In reply to comment #6) > (In reply to comment #5) > > Created an attachment (id=83156) [details] [details] > > Proposed patch > > > > This patch fixes the issue for GTK, ossy is this enough for Qt? > > Unfortunately QtWebKit still crashes with this patch. For the crash log it seems it does not find the plugin, probably we have to add the source file to the make file?
Csaba Osztrogonác
Comment 8 2011-02-21 07:11:33 PST
Created attachment 83162 [details] GDB backtrace in debug mode (on Qt) $ Tools/Scripts/run-webkit-tests --verbose --debug plugins/get-url-with-javascript-destroying-plugin.html plugins/get-user-agent-with-null-npp-from-npp-new.html
Csaba Osztrogonác
Comment 9 2011-02-21 07:15:11 PST
(In reply to comment #7) > For the crash log it seems it does not find the plugin, probably we have to add the source file to the make file? r79157 added Tests/GetURLWithJavaScriptURLDestroyingPlugin.cpp to the project: http://trac.webkit.org/changeset/79157/trunk/Tools/DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro
Alejandro G. Castro
Comment 10 2011-02-21 09:55:57 PST
aroben fixed the issue apparently. *** This bug has been marked as a duplicate of bug 54884 ***
Adam Roben (:aroben)
Comment 11 2011-02-21 09:57:26 PST
Whoops, sorry for not noticing this bug before filing bug 54884.
Alejandro G. Castro
Comment 12 2011-02-21 10:39:55 PST
And it still fails in GTK :), we need to add the file to the makefile. I'm going to reopen, add a dependency on the other bug and update the patch.
Csaba Osztrogonác
Comment 13 2011-02-21 10:41:58 PST
Unskip test for Qt: http://trac.webkit.org/changeset/79235
Alejandro G. Castro
Comment 14 2011-02-21 10:56:22 PST
Created attachment 83191 [details] Proposed patch
Csaba Osztrogonác
Comment 15 2011-02-21 10:57:23 PST
Comment on attachment 83191 [details] Proposed patch LGTM, r=me.
Alejandro G. Castro
Comment 16 2011-02-21 11:08:29 PST
Landed http://trac.webkit.org/changeset/79237 Hrm, not sure what EWS tested.
Note You need to log in before you can comment on or make changes to this bug.