Bug 5486

Summary: DumpRenderTree should print the RTL and directional override flags for text runs
Product: WebKit Reporter: mitz
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: VERIFIED FIXED    
Severity: Enhancement    
Priority: P3    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Dump bidi flags
darin: review+
expected results diffs
none
expected results diff none

Description mitz 2005-10-24 14:40:40 PDT 
In order to make bidi regressions more detectable by the layout tests, render tree dumps should indicate if 
m_reversed or m_dirOverride is set for every inlineTextBox. Printing the flag only when it's set means that 
most expected results won't have to be updated.
Comment 1 Darin Adler 2005-10-24 14:47:40 PDT 
Sounds like a good idea.
Comment 2 mitz 2005-10-24 15:01:55 PDT 
Created attachment 4463 [details]
Dump bidi flags
Comment 3 mitz 2005-10-24 15:07:47 PDT 
Comment on attachment 4463 [details]
Dump bidi flags

After (some revision of) this is accepted, I'll diff the expected results.
Comment 4 Darin Adler 2005-10-24 15:25:01 PDT 
Comment on attachment 4463 [details]
Dump bidi flags

Look fine. Lets do it!
Comment 5 mitz 2005-10-24 16:20:29 PDT 
Created attachment 4464 [details]
expected results diffs

Diffs for all tests that the patch affects except
fast/text/international/bidi-explicit-embedding, whose expected results are out
of date following the patch for bug 5414.
Comment 6 mitz 2005-10-24 16:53:36 PDT 
Created attachment 4465 [details]
expected results diff

added bidi-explicit-embedding