Bug 5486

Summary: DumpRenderTree should print the RTL and directional override flags for text runs
Product: WebKit Reporter: mitz
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: VERIFIED FIXED    
Severity: Enhancement    
Priority: P3    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Dump bidi flags
darin: review+
expected results diffs
none
expected results diff none

mitz
Reported 2005-10-24 14:40:40 PDT
In order to make bidi regressions more detectable by the layout tests, render tree dumps should indicate if m_reversed or m_dirOverride is set for every inlineTextBox. Printing the flag only when it's set means that most expected results won't have to be updated.
Attachments
Dump bidi flags (972 bytes, patch)
2005-10-24 15:01 PDT, mitz 		darin: review+
DetailsFormatted DiffDiff
expected results diffs (145.48 KB, patch)
2005-10-24 16:20 PDT, mitz 		no flags
DetailsFormatted DiffDiff
expected results diff (152.42 KB, patch)
2005-10-24 16:53 PDT, mitz 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2005-10-24 14:47:40 PDT
Sounds like a good idea.
mitz
Comment 2 2005-10-24 15:01:55 PDT
Created attachment 4463 [details] Dump bidi flags
mitz
Comment 3 2005-10-24 15:07:47 PDT
Comment on attachment 4463 [details] Dump bidi flags After (some revision of) this is accepted, I'll diff the expected results.
Darin Adler
Comment 4 2005-10-24 15:25:01 PDT
Comment on attachment 4463 [details] Dump bidi flags Look fine. Lets do it!
mitz
Comment 5 2005-10-24 16:20:29 PDT
Created attachment 4464 [details] expected results diffs Diffs for all tests that the patch affects except fast/text/international/bidi-explicit-embedding, whose expected results are out of date following the patch for bug 5414.
mitz
Comment 6 2005-10-24 16:53:36 PDT
Created attachment 4465 [details] expected results diff added bidi-explicit-embedding
Note You need to log in before you can comment on or make changes to this bug.