Bug 5484

Summary: REGRESSION: reproducible crash in CachedCSSStyleSheet::setCharset
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: VERIFIED FIXED    
Severity: Critical    
Priority: P1    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
URL: http://www.czechairlines.com
Attachments:
Description Flags
proposed fix darin: review+

Alexey Proskuryakov
Reported 2005-10-24 13:24:36 PDT
Steps to reproduce: open http://www.czechairlines.com in ToT Results: complains about memory trashing in the console; occasionally crashes. Caused by my fix to bug 5140 - ironically, I was running with that patch locally applied for a month, but saw this crash only the day it was committed :(
Attachments
proposed fix (927 bytes, patch)
2005-10-24 13:25 PDT, Alexey Proskuryakov 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2005-10-24 13:25:09 PDT
Created attachment 4461 [details] proposed fix
Darin Adler
Comment 2 2005-10-24 13:57:42 PDT
Comment on attachment 4461 [details] proposed fix Oops! r=me
Timothy Hatcher
Comment 3 2005-10-24 14:44:52 PDT
I am landing this.
Timothy Hatcher
Comment 4 2005-10-24 14:51:42 PDT
/cvs/root/WebCore/ChangeLog,v <-- ChangeLog new revision: 1.274; previous revision: 1.273 Checking in khtml/misc/loader.cpp; /cvs/root/WebCore/khtml/misc/loader.cpp,v <-- loader.cpp new revision: 1.80; previous revision: 1.79
Note You need to log in before you can comment on or make changes to this bug.