Bug 54821 – REGRESSION: Images are missing on tobii.com main page

• Component: Page Loading
• Status: RESOLVED INVALID

[Alin S]

the site fails to load alltogether while it loads fine in STOCK safari 5.0.3 have no other browsers to cross test. NO webkit build all the way back to last november 30th will load the site. This is a MAJOR fault with Webkit!!!

The ONLY unaffected device here that runs on webkit is my 2.2 FROYO android phone.

This bug needs to be fixed ASAP.

I will do whatever I can to help provide files. and stuff to get it fixed

I am getting the developer from Tobii involved, for now i have my contact there as the CC so he will receive this bug and FWD it to the web engineer. however since it functions fine on much older webkit builds (Safari 5.0.3 and ANDROID 2.2 FROYO) this proves that there is a MAJOR problem involving the new versions of webkit!!! and not the site!!!

[Alin S]

Created attachment 83088 [details]
FAILED LOAD ON NIGHTLY! Version 5.0.3 (6533.19.4, r78794)

Version 5.0.3 (6533.19.4, r78794) LOAD FAILS!

[Alin S]

Created attachment 83089 [details]
improper load of homepage

there should be 3 images including in the assistive technology a cute smiling girl

[Alin S]

Created attachment 83090 [details]
PROPER LOAD. SHows smiling girl Version 5.0.3 (6533.19.4)

[Alin S]

Created attachment 83091 [details]
Working load of what failed in the first attachment

[Alexey Proskuryakov]

<rdar://problem/9028963>

[Andy Estes]

This is due to <http://trac.webkit.org/changeset/69516>, which implements ES5 strict mode. The page requests strict mode ("use strict" is the first line of the main resource) and then encounters the following error:

TypeError: 'undefined' is not an object (evaluating 'n.jQuery')

[Andy Estes]

Actually 'use strict' is in an external script resource, not the main resource. I'm working on a reduction.

[Oliver Hunt]

It looks like someone has simply placed "use strict" at the beginning of some jquery plugins or some such.  This is unsafe and incorrect as strict mode does alter language semantics.

For reference this site also does not work in firefox 4, and won't work in any other js engine that implements strict mode (so fairly soon it won't work in chrome or opera either)

[Alin S]

I am reopening this bug, this is a site that has to do with assistive tech. if it worked in an older build of safari then why should it not be preserved now? hmm???

if you feel the bug is "invalid" then why would you place it in radar!!!

[Andy Estes]

Specifically, it's this code in the resource http://www.tobii.com/combres.axd/siteJs/244318681:

(function() {
    var n = this,
           x = n.jQuery,
    ...
})();

'this' is undefined in strict mode due to the context. Non-strict behavior is to default 'this' to the global object (a DOMWindow), but this is no longer the case in strict mode.

Oliver can probably give a more precise explanation if needed.

[Oliver Hunt]

(In reply to comment #9)
> I am reopening this bug, this is a site that has to do with assistive tech. if it worked in an older build of safari then why should it not be preserved now? hmm???
> 
> if you feel the bug is "invalid" then why would you place it in radar!!!

Because we automatically put all bugs into radar.

It worked in old versions of safari because old versions of safari did not support the strict mode feature.  Neither did firefox, chrome, or opera.

All of these browsers have now either implemented support for strict mode, or are in the process of doing so.  This site will not work in _any_ browser that supports strict mode, as the code in the site is wrong.

There is script in the site that starts with "use strict", this was clearly not actually tested as no browser supported any part of strict mode until about maybe 6 months ago.  Now that browsers support it, they're exposing the fact that the code is not in fact correct.

Even amazon.com has had to fix a few of their pages where they had incorrectly pasted "use strict" at the beginning of scripts, and this site is no different.  The code is wrong and needs to be fixed on the site, not in the browser.

[Alin S]

Mail sent to Tobii director

"get this to your web developer STAT. it is absolutely CRITICAL as tobii.com will NO LONGER WORK ON ALL BROWSERS SHORTLY

Begin forwarded message:

From: [e-mail]
Date: February 21, 2011 6:31:33 PM CST
To: [e-mail]
Subject: [Bug 54821] REGRESSION: Images are missing on tobii.com main page

https://bugs.webkit.org/show_bug.cgi?id=54821





--- Comment #11 from Oliver Hunt <[e-mail]>  2011-02-21 16:31:33 PST ---
(In reply to comment #9)
I am reopening this bug, this is a site that has to do with assistive tech. if it worked in an older build of safari then why should it not be preserved now? hmm???

if you feel the bug is "invalid" then why would you place it in radar!!!

Because we automatically put all bugs into radar.

It worked in old versions of safari because old versions of safari did not support the strict mode feature.  Neither did firefox, chrome, or opera.

All of these browsers have now either implemented support for strict mode, or are in the process of doing so.  This site will not work in _any_ browser that supports strict mode, as the code in the site is wrong.

There is script in the site that starts with "use strict", this was clearly not actually tested as no browser supported any part of strict mode until about maybe 6 months ago.  Now that browsers support it, they're exposing the fact that the code is not in fact correct.

Even amazon.com has had to fix a few of their pages where they had incorrectly pasted "use strict" at the beginning of scripts, and this site is no different.  The code is wrong and needs to be fixed on the site, not in the browser.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You reported the bug.
"