Bug 54809

Summary: [EFL] Frame flattening option for EWebLauncher
Product: WebKit Reporter: Lukasz Slachciak <l.slachciak>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, kenneth, leandro, l.slachciak, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on: 44253    
Bug Blocks:    
Attachments:
Description Flags
frame flattening for EWebLauncher
none
frame flattening for EWebLauncher none

Lukasz Slachciak
Reported 2011-02-19 10:12:39 PST
Attached patch adds -f option for EWebLauncher to create view with frame flattening enabled/disabled
Attachments
frame flattening for EWebLauncher (5.52 KB, patch)
2011-02-19 10:17 PST, Lukasz Slachciak 		no flags
DetailsFormatted DiffDiff
frame flattening for EWebLauncher (5.42 KB, patch)
2011-02-21 15:17 PST, Lukasz Slachciak 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Lukasz Slachciak
Comment 1 2011-02-19 10:17:34 PST
Created attachment 83078 [details] frame flattening for EWebLauncher
Gyuyoung Kim
Comment 2 2011-02-20 18:40:41 PST
Comment on attachment 83078 [details] frame flattening for EWebLauncher View in context: https://bugs.webkit.org/attachment.cgi?id=83078&action=review Looks good to me. :-) > Tools/ChangeLog:6 > + https://webkit.org/b/54809 Bug url is strange. Please fix it with https://bugs.webkit.org/show_bug.cgi?id=54809
Gyuyoung Kim
Comment 3 2011-02-20 18:42:52 PST
Comment on attachment 83078 [details] frame flattening for EWebLauncher View in context: https://bugs.webkit.org/attachment.cgi?id=83078&action=review > Tools/ChangeLog:7 > + Please add summary of this patch.
Lukasz Slachciak
Comment 4 2011-02-21 15:17:54 PST
Created attachment 83224 [details] frame flattening for EWebLauncher
Lukasz Slachciak
Comment 5 2011-02-21 15:19:54 PST
Hello Gyuyoung. I extended url in ChangeLog and added short note.
Lukasz Slachciak
Comment 6 2011-02-24 22:33:37 PST
So looks like we are waiting for reviewer now :)
Gyuyoung Kim
Comment 7 2011-02-25 00:08:53 PST
(In reply to comment #6) > So looks like we are waiting for reviewer now :) Yes, It looks reviewers are busy. I think Antonio will review this patch. :-)
Gyuyoung Kim
Comment 8 2011-02-25 00:12:57 PST
Comment on attachment 83224 [details] frame flattening for EWebLauncher Hello kenneth, Thank you for your review :-)
WebKit Commit Bot
Comment 9 2011-02-25 23:55:23 PST
Comment on attachment 83224 [details] frame flattening for EWebLauncher Clearing flags on attachment: 83224 Committed r79761: <http://trac.webkit.org/changeset/79761>
WebKit Commit Bot
Comment 10 2011-02-25 23:55:29 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.