| Summary: | Change jsc target to build directly into JavaScriptCore.framework/Resources/jsc | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
| Component: | JavaScriptCore | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | barraclough, ggaren, mrowe, oliver, timothy | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
Testing details: - Release and Debug configurations still build jsc into $BUILT_PRODUCTS_DIR, jsc is still copied into $BUILT_PRODUCTS_DIR/JavaScriptCore.framework/Resources/jsc and the loader_path is still updated for $BUILT_PRODUCTS_DIR/JavaScriptCore.framework/Resources/jsc. - Production builds (via buildit) still build jsc into $SYSTEM_LIBRARY_DIR/Frameworks/JavaScriptCore.framework/Resources/jsc with the loader_path unchanged (as before). Committed r79131: <http://trac.webkit.org/changeset/79131> |
Created attachment 83077 [details] Patch Reviewed by NOBODY (OOPS!). * Configurations/Base.xcconfig: Added JAVASCRIPTCORE_FRAMEWORKS_DIR variable. * Configurations/JavaScriptCore.xcconfig: Used JAVASCRIPTCORE_FRAMEWORKS_DIR to define INSTALL_PATH. * JavaScriptCore.xcodeproj/project.pbxproj: Set the INSTALL_PATH for Production configuration of jsc target. (Copy Into Framework): Removed old build phase. (Fix Framework Reference): Renamed build phase to "Copy Into Framework". Added "set -x" call to make the script print the commands it is running. Added code to exit early for Production builds since this was never intended for them. Added code to copy jsc into the JavaScriptCore.framework/Resources directory. --- 4 files changed, 31 insertions(+), 21 deletions(-)