Bug 54753 – REGRESSION(r79003): It broke tests on GTK bots (Requested by Ossy on #webkit).

• Component: New Bugs
• Status: RESOLVED INVALID

[WebKit Review Bot]

http://trac.webkit.org/changeset/79003 broke the build:
It broke tests on GTK bots (Requested by Ossy on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 82968 [details]
ROLLOUT of r79003

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.

[Csaba Osztrogonác]

Comment on attachment 82968 [details]
ROLLOUT of r79003

Rollout patch landed in http://trac.webkit.org/changeset/79005

I have no idea what happened on GTK bots ... 
I leave the bug open and will check it on monday.

[Balazs Kelemen]

(In reply to comment #2)
> (From update of attachment 82968 [details])
> Rollout patch landed in http://trac.webkit.org/changeset/79005
> 
> I have no idea what happened on GTK bots ... 

Ok, but at least tell us what was the symptom? :)
Was it a crash, a layout failure, or a compile error?

[Csaba Osztrogonác]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 82968 [details] [details])
> > Rollout patch landed in http://trac.webkit.org/changeset/79005
> > 
> > I have no idea what happened on GTK bots ... 
> 
> Ok, but at least tell us what was the symptom? :)
> Was it a crash, a layout failure, or a compile error?

Feel free to check it yourself: http://build.webkit.org . ;)

[Balazs Kelemen]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 82968 [details] [details])
> > Rollout patch landed in http://trac.webkit.org/changeset/79005
> > 
> > I have no idea what happened on GTK bots ... 
> 
> Ok, but at least tell us what was the symptom? :)
> Was it a crash, a layout failure, or a compile error?

Ok, I have just realized that it was your patch, so it was not so
rude rolling it out and it's your business to fixing it ;)