Bug 54746

Summary: QtWebKit fails to compile on Windows XP with msvc-2008
Product: WebKit Reporter: Kristian Amlie <kristian.amlie>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Blocker CC: commit-queue, darin, kling
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
Patch
none
Proper-fix none

Kristian Amlie
Reported 2011-02-18 06:57:34 PST
It fails because of a missing friend declaration. A check for the Qt platform is needed to enable the declaration.
Attachments
Patch (2.15 KB, patch)
2011-02-18 07:00 PST, Kristian Amlie 		no flags
DetailsFormatted DiffDiff
Proper-fix (2.29 KB, patch)
2011-02-21 02:54 PST, Kristian Amlie 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kristian Amlie
Comment 1 2011-02-18 07:00:08 PST
Created attachment 82957 [details] Patch
Andreas Kling
Comment 2 2011-02-18 07:45:16 PST
Comment on attachment 82957 [details] Patch r=me
WebKit Commit Bot
Comment 3 2011-02-18 19:53:10 PST
Comment on attachment 82957 [details] Patch Clearing flags on attachment: 82957 Committed r79083: <http://trac.webkit.org/changeset/79083>
WebKit Commit Bot
Comment 4 2011-02-18 19:53:15 PST
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 5 2011-02-20 17:38:53 PST
This was an incorrect fix. The correct way to do this would be to make it conditional on the compiler, which is where the limitation lies, instead of PLATFORM. The fix should be redone correctly.
Kristian Amlie
Comment 6 2011-02-21 02:53:53 PST
Reopening to fix properly.
Kristian Amlie
Comment 7 2011-02-21 02:54:58 PST
Created attachment 83143 [details] Proper-fix
Andreas Kling
Comment 8 2011-02-21 03:27:39 PST
(In reply to comment #5) > This was an incorrect fix. The correct way to do this would be to make it conditional on the compiler, which is where the limitation lies, instead of PLATFORM. The fix should be redone correctly. Yes indeed, that's my bad.
WebKit Commit Bot
Comment 9 2011-02-21 05:10:29 PST
Comment on attachment 83143 [details] Proper-fix Clearing flags on attachment: 83143 Committed r79211: <http://trac.webkit.org/changeset/79211>
WebKit Commit Bot
Comment 10 2011-02-21 05:10:34 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.