Bug 54727

Summary: elements remain focusable after tabindex is removed
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: arv, commit-queue, tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
test case
none
Patch none

Ojan Vafai
Reported 2011-02-17 23:38:53 PST
Created attachment 82928 [details] test case An element with tabindex is focusable. But if tabindex is removed it should return to not being focusable. I've confirmed gecko removes focusability. See the test case.
Attachments
test case (165 bytes, text/html)
2011-02-17 23:38 PST, Ojan Vafai 		no flags
Details
Patch (5.08 KB, patch)
2011-02-20 19:16 PST, James Kozianski 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2011-02-17 23:39:19 PST
FWIW, this is causing some annoying UI issues for the code review tool.
James Kozianski
Comment 2 2011-02-20 19:16:19 PST
Created attachment 83117 [details] Patch
Kent Tamura
Comment 3 2011-02-20 21:18:47 PST
Comment on attachment 83117 [details] Patch Looks good.
WebKit Review Bot
Comment 4 2011-02-21 13:29:54 PST
Comment on attachment 83117 [details] Patch Rejecting attachment 83117 [details] from commit-queue. koz@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
WebKit Commit Bot
Comment 5 2011-02-21 17:27:24 PST
Comment on attachment 83117 [details] Patch Clearing flags on attachment: 83117 Committed r79269: <http://trac.webkit.org/changeset/79269>
WebKit Commit Bot
Comment 6 2011-02-21 17:27:29 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.