Bug 54698

Summary: we should skip webkitpy.layout_tests.port.mac_unittest's test_skipped_file_path on win32, because it fails otherwise
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: Tools / TestsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aroben, eric, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Patch aroben: review+

Dirk Pranke
Reported 2011-02-17 17:43:39 PST
we should skip webkitpy.layout_tests.port.mac_unittest's test_skipped_file_path on win32, because it fails due to hardcoded '/' as dir separators and there's no point in rewriting the test just for win32.
Attachments
Patch (1.82 KB, patch)
2011-02-17 19:32 PST, Dirk Pranke 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2011-02-17 19:32:11 PST
Created attachment 82904 [details] Patch
Adam Roben (:aroben)
Comment 2 2011-02-17 19:36:37 PST
Comment on attachment 82904 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82904&action=review > Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py:53 > + if sys.platform == 'win32': > + return None Maybe add a comment about why we're skipping this?
Dirk Pranke
Comment 3 2011-02-18 15:42:48 PST
Committed r79045: <http://trac.webkit.org/changeset/79045>
Note You need to log in before you can comment on or make changes to this bug.