Bug 54675

Summary: Web Inspector: highlighted line does not span horizonally in scripts panel while debugging.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aandrey, apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, podivilov, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Description Pavel Feldman 2011-02-17 11:02:59 PST 
1. Load a script with horizontal scrollbar
2. Set breakpoint
3. Stop on breakpoint
4. Move scroller

Expected - highlighted bar spans
Actual - trimmed.
Comment 1 Yury Semikhatsky 2011-02-17 11:11:18 PST 
The same issue with error highlights.
Comment 2 Andrey Adaikin 2011-03-02 04:45:29 PST 
Created attachment 84400 [details]
Patch
Comment 3 Pavel Feldman 2011-03-02 05:10:22 PST 
Comment on attachment 84400 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84400&action=review

> Source/WebCore/inspector/front-end/TextViewer.js:684
> +    this._container.tabIndex = 0;

tabIndex is used to make element focusable so that it could receive keyboard input events. Do you need it for both components?
Comment 4 Andrey Adaikin 2011-03-02 05:15:32 PST 
Created attachment 84405 [details]
Patch
Comment 5 Pavel Podivilov 2011-03-02 05:46:17 PST 
Comment on attachment 84405 [details]
Patch

Clearing flags on attachment: 84405

Committed r80119: <http://trac.webkit.org/changeset/80119>
Comment 6 Pavel Podivilov 2011-03-02 05:46:26 PST 
All reviewed patches have been landed.  Closing bug.