Bug 54654

Summary: accessibility/canvas-fallback-content.html failing on Windows since it was added
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: AccessibilityAssignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cfleizach, dmazzoni, peavo, pvollan
Priority: P2 Keywords: InRadar, LayoutTestFailure, PlatformOnly
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
URL: http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r78795%20(9461)/accessibility/canvas-fallback-content-pretty-diff.html
Attachments:
Description Flags
Patch aroben: review-

Description Adam Roben (:aroben) 2011-02-17 07:04:23 PST
accessibility/canvas-fallback-content.html has been failing on Windows since it was added in r78789. See the URL for an example of the failure.
Comment 1 Adam Roben (:aroben) 2011-02-17 07:14:13 PST
<rdar://problem/9016973>
Comment 2 chris fleizach 2011-02-17 07:50:07 PST
we need to add a skip for this test for windows for now
Comment 3 chris fleizach 2011-02-17 07:52:50 PST
Created attachment 82804 [details]
Patch
Comment 4 Adam Roben (:aroben) 2011-02-17 08:04:16 PST
Checked in expected failure results in r78829.
Comment 5 Adam Roben (:aroben) 2011-02-17 08:04:49 PST
Comment on attachment 82804 [details]
Patch

I already checked in expected failure results for this test. Sorry for not mentioning I was going to do that!
Comment 6 Dominic Mazzoni 2011-02-17 08:12:12 PST
Thanks for taking care of the test expectations, and I'm sorry I didn't do that as part of the original test!

It looks like most of the accessibility tests (>75%) are already disabled on Windows, so it's not clear to me if I should try to fix this one. Options include:

1. If accessibilityController.focusedElement.allAttributes() is supported on Windows, modify the test to look for the appropriate Windows-specific attributes.

2. If not, modify the test to just check for the activeElement.id on Windows and ignore the role.

3. Or, do nothing for now until Windows a11y infrastructure improves.
Comment 7 Adam Roben (:aroben) 2011-02-17 08:28:21 PST
Chris, do you know why so many accessibility tests are skipped on Windows? Are we missing some support in DRT? Are the tests inherently Mac-specific?
Comment 8 Dominic Mazzoni 2011-02-17 08:33:16 PST
A quick grep shows that 43 of the tests (including this one) test for the Mac-specific accessibility attributes of an object in the render tree. (Anything starting with AX like AXRole or AXImage is Mac-only.)

It might be possible to redo some of the test infrastructure to expose WebCore roles rather than platform-specific roles.

We'd still want some platform-specific tests, but those could be moved to the appropriate platform subdirectories.
Comment 9 Adam Roben (:aroben) 2011-02-17 08:42:29 PST
(In reply to comment #8)
> A quick grep shows that 43 of the tests (including this one) test for the Mac-specific accessibility attributes of an object in the render tree. (Anything starting with AX like AXRole or AXImage is Mac-only.)
> 
> It might be possible to redo some of the test infrastructure to expose WebCore roles rather than platform-specific roles.

That might be a good idea.

> We'd still want some platform-specific tests, but those could be moved to the appropriate platform subdirectories.

Agreed. We should probably start by moving any existing platform-specific tests into platform subdirectories. We can (and should) do that right away without having to figure out a long-term strategy.
Comment 10 chris fleizach 2011-02-17 12:42:16 PST
(In reply to comment #7)
> Chris, do you know why so many accessibility tests are skipped on Windows? Are we missing some support in DRT? Are the tests inherently Mac-specific?

Most of the top level AX tests are pretty mac specific, but have never been moved out. There are some platform agnostic tests but not that many. As a stop gap, I think people have just disabled tests on windows, since there are so few windows-accessibility devs
Comment 11 Dominic Mazzoni 2012-05-10 11:58:45 PDT
This doesn't apply anymore, the original patch that added it was reverted a long time ago.