Bug 54648

Summary:

Allow custom memory allocation control for missing classes of WebCore

Product:

WebKit

Reporter:

Zoltan Horvath <zoltan>

Component:

WebCore Misc.

Assignee:

Zoltan Horvath <zoltan>

Status:

NEW

Severity:

Normal

CC:

buildbot, ossy, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
proposed patch	ossy: review-

Zoltan Horvath

Reported 2011-02-17 06:39:09 PST

Add WTF_MAKE_FAST_ALLOCATED macro to the following classes, because these are instantiated by operator 'new'. * html/parser/HTMLMetaCharsetParser.h: HTMLMetaCharsetParser, instatiated at: html/parser/HTMLMetaCharsetParser.h:42 * html/parser/HTMLToken.h: DoctypeData, instantiated at: html/parser/HTMLToken.h:137 * inspector/InspectorDOMAgent.h: InspectorCSSAgent, instantiated at: inspector/InspectorAgent.cpp:140 * inspector/InspectorStyleSheet.cpp: ParsedStyleSheet, instantiated at: inspector/InspectorStlyeSheet.cpp:596 * page/GeolocationPositionCache.h: GeolocationPositonCache, instantiated at: page/GeolocationPositionCache.cpp:51

Attachments
proposed patch (3.81 KB, patch) 2011-02-17 06:40 PST, Zoltan Horvath	ossy: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Zoltan Horvath

Comment 1 2011-02-17 06:40:21 PST

Created attachment 82793 [details] proposed patch

WebKit Review Bot

Comment 2 2011-02-17 06:42:40 PST

Attachment 82793 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/html/parser/HTMLMetaCharsetParser.h:40: More than one command on the same line [whitespace/newline] [4] Source/WebCore/html/parser/HTMLToken.h:343: More than one command on the same line [whitespace/newline] [4] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 3 2011-02-17 07:11:49 PST

Attachment 82793 [details] did not build on win: Build output: http://queues.webkit.org/results/7919763

Csaba Osztrogonác

Comment 4 2011-02-21 14:49:38 PST

Comment on attachment 82793 [details] proposed patch r- due to windows build break. Please fix it and upload a new patch.

Note You need to log in before you can comment on or make changes to this bug.