Bug 54639

Summary:

Navigating downwards / upwards does not focus on the links spread across more than one line.

Product:

WebKit

Reporter:

deepak <deepak.dhananjaya>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Blocker

CC:

ademar, suresh.voruganti, tonikitoo, yael

Priority:

Keywords:

Version:

528+ (Nightly build)

Hardware:

S60 Hardware

OS:

S60 3rd edition

Attachments:

Description	Flags
widget	none
Test page attached.	none
Patch.	tonikitoo: review+, yael: commit-queue+
Backport	none

deepak

Reported 2011-02-17 05:06:42 PST

Attachment : includes a webpage, that has link that is spread across two lines. Steps: 1. Open the page, and navigate use key pad in the mobile hardware to navigate the links. Expected Result: The link that is spread across two lines also should be selected and focused. Actual REsult: The link that is spread across two lines is skipped and the next link is selected and focused.

Attachments
widget (2.35 KB, application/x-zip-compressed) 2011-02-17 08:35 PST, Murali Alluri	no flags	Details
Test page attached. (2.39 KB, text/html) 2011-02-17 09:26 PST, deepak	no flags	Details
Patch. (10.18 KB, patch) 2011-02-18 05:25 PST, Yael	tonikitoo: review+ yael: commit-queue+	Details Formatted Diff Diff
Backport (10.60 KB, patch) 2011-02-22 14:42 PST, Yael	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

deepak

Comment 1 2011-02-17 05:08:42 PST

Additional Info: Tested this with QTTestBrowser, and it is reproducible on the same.

deepak

Comment 2 2011-02-17 05:42:08 PST

Additional Info: Since QTTestBrowser does not support key pad navigation, enabled the setting through code in webpage. this->settings()->setAttribute(QWebSettings::SpatialNavigationEnabled, true); After which, was able to test this test case.

Yael

Comment 3 2011-02-17 07:30:59 PST

(In reply to comment #0) > Attachment : includes a webpage, that has link that is spread across two lines. > > Steps: > 1. Open the page, and navigate use key pad in the mobile hardware to navigate the links. > > Expected Result: > The link that is spread across two lines also should be selected and focused. > > Actual REsult: > The link that is spread across two lines is skipped and the next link is selected and focused. Please include the attachment.

Murali Alluri

Comment 4 2011-02-17 08:35:45 PST

Created attachment 82814 [details] widget

deepak

Comment 5 2011-02-17 09:26:55 PST

Created attachment 82820 [details] Test page attached.

Yael

Comment 6 2011-02-17 18:06:21 PST

Removing [Qt][S60] as the fix is in common code. Patch is coming soon.

Yael

Comment 7 2011-02-18 05:25:41 PST

Created attachment 82946 [details] Patch. When 2 anchor elements span more than one line each, and one ends on the same line that the second starts on, the rects reported by their renderers are overlapping. When handling 2 overlapping nodes, check for this case, and don't assume that one of the nodes is on a higher layer.

Yael

Comment 8 2011-02-18 06:49:52 PST

Comment on attachment 82946 [details] Patch. Thanks for the review :)

Yael

Comment 9 2011-02-18 13:07:46 PST

Committed r79021: <http://trac.webkit.org/changeset/79021>

Suresh Voruganti

Comment 10 2011-02-21 07:21:45 PST

Please cherry pick the fix for Qtwebkit 2.1

Ademar Reis

Comment 11 2011-02-21 12:00:06 PST

(In reply to comment #10) > Please cherry pick the fix for Qtwebkit 2.1 The code requires significant changes to be cherry-picked. We need a backport targeted at qtwebkit-2.1.

Yael

Comment 12 2011-02-22 14:42:29 PST

Created attachment 83393 [details] Backport This is a backport of the original patch to qtwebkit-2.1.x

Ademar Reis

Comment 13 2011-02-25 11:58:05 PST

Revision r79021 cherry-picked into qtwebkit-2.1 with commit 3721aa1 <http://gitorious.org/webkit/qtwebkit/commit/3721aa1>

Note You need to log in before you can comment on or make changes to this bug.