Bug 54638

Summary: Web Inspector: [Chromium] inspector/debugger/dom-breakpoints.html TIMEOUTs
Product: WebKit Reporter: Mikhail Naganov <mnaganov>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed change.
none
Patch yurys: review+

Mikhail Naganov
Reported 2011-02-17 04:53:57 PST
The test was initially disabled and marked as BUGPFELDMAN. I tried running it locally (on Linux) -- it timeouts.
Attachments
[PATCH] Proposed change. (36.60 KB, patch)
2011-02-18 10:59 PST, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Patch (38.03 KB, patch)
2011-02-21 03:11 PST, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-02-18 10:59:20 PST
Created attachment 82982 [details] [PATCH] Proposed change.
Yury Semikhatsky
Comment 2 2011-02-21 03:01:52 PST
Comment on attachment 82982 [details] [PATCH] Proposed change. View in context: https://bugs.webkit.org/attachment.cgi?id=82982&action=review > LayoutTests/http/tests/inspector/inspector-test.js:164 > + var wrapThis = this; Wrong indentation. > LayoutTests/http/tests/inspector/inspector-test.js:178 > +$wrap = InspectorTest.safeWrap; What's the reason for introducing the new sytax? Please use InspectorTest.safeWrap directly.
Pavel Feldman
Comment 3 2011-02-21 03:11:15 PST
Created attachment 83144 [details] Patch
Pavel Feldman
Comment 4 2011-02-21 03:13:12 PST
Committed r79205: <http://trac.webkit.org/changeset/79205>
Note You need to log in before you can comment on or make changes to this bug.