Bug 54607

Summary:

[chromium] Split WebURLResponse's socketAddress into separate host and port fields

Product:

WebKit

Reporter:

Brian Ryner <bryner>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, fishd

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
patch	none

Brian Ryner

Reported 2011-02-16 18:25:10 PST

Rather than representing the remote socket address as "host:port", it will be less error-prone to just have separate host and port members. In particular, with IPv6 literals, this avoids the caller needing to parse a bracketed IP address when trying to split apart the IP and the port number.

Attachments
patch (7.91 KB, patch) 2011-02-16 20:47 PST, Brian Ryner	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Brian Ryner

Comment 1 2011-02-16 20:47:58 PST

Created attachment 82749 [details] patch

WebKit Commit Bot

Comment 2 2011-02-16 22:25:18 PST

Comment on attachment 82749 [details] patch Clearing flags on attachment: 82749 Committed r78790: <http://trac.webkit.org/changeset/78790>

WebKit Commit Bot

Comment 3 2011-02-16 22:25:22 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.