Bug 54567

Summary: Drop "Windows;" (redundant) from user agent string
Product: WebKit Reporter: Peter Kasting <pkasting>
Component: PlatformAssignee: Peter Kasting <pkasting>
Severity: Normal CC: commit-queue, eric, fishd, jamesr, jorlow, mihaip
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Bug Depends on:    
Bug Blocks: 54556    
Description Flags
patch v1
jamesr: review+, commit-queue: commit-queue-
Updated patch none

Description Peter Kasting 2011-02-16 10:09:47 PST
This is about dropping the initial "Windows;" due to its redundancy with the subsequent "Windows NT 6.0;" (or similar other version identifier).  See blocked bug 54556 for motivation.
Comment 1 Peter Kasting 2011-02-24 13:42:49 PST
Created attachment 83710 [details]
patch v1

I have mailed the Mozilla guys on why "Macintosh;" was not also dropped (they explain why "X11;" was not dropped), but I bet the answer is going to be "web compat", as "Windows" is a string still found in the updated Windows-specific UA string (in the version identifier) but "Macintosh" would not be found in a similarly-updated Mac UA string (which uses "Mac OS" in the version identifier).
Comment 2 Peter Kasting 2011-02-25 10:16:54 PST
Response from Mozilla: the motivation for dropping "Windows;" is primarily to match IE better (as IE has never had this token), only secondarily because it's redundant.

This is a stronger motivation than just "the token could be removed" and also explains why "Macintosh" was not dropped.
Comment 3 Peter Kasting 2011-03-01 18:16:28 PST
Ping?  I'd really like to land this soon so all the UA string changes happen in a short window.
Comment 4 James Robinson 2011-03-02 12:58:28 PST
Comment on attachment 83710 [details]
patch v1

Let's do it.
Comment 5 WebKit Commit Bot 2011-03-02 13:06:41 PST
Comment on attachment 83710 [details]
patch v1

Rejecting attachment 83710 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'apply-..." exit_code: 2

Last 500 characters of output:
k #3 succeeded at 3727 (offset -1 lines).
patching file Source/WebKit/win/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit/win/WebView.cpp
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/http/tests/navigation/useragent-expected.txt
patching file LayoutTests/http/tests/navigation/useragent.php

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'James Robinson', u'--f..." exit_code: 1

Full output: http://queues.webkit.org/results/8084070
Comment 6 Peter Kasting 2011-03-02 13:38:52 PST
Created attachment 84457 [details]
Updated patch

Updated to apply against current trunk.
Comment 7 WebKit Commit Bot 2011-03-03 02:25:04 PST
Comment on attachment 84457 [details]
Updated patch

Clearing flags on attachment: 84457

Committed r80218: <http://trac.webkit.org/changeset/80218>
Comment 8 WebKit Commit Bot 2011-03-03 02:25:10 PST
All reviewed patches have been landed.  Closing bug.