Bug 54562

Summary:

Web Inspector: remove platform specifics from node highlight routines.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

apavlov, buildbot, bweinstein, gustavo.noronha, gustavo, jamesr, joepeck, keishi, loislo, pfeldman, pmuellr, rik, simon.fraser, vsevik, webkit-ews, xan.lopez, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	pfeldman: review-
[PATCH] For bots	none
Patch	simon.fraser: review-, gustavo.noronha: commit-queue-

Pavel Feldman

Reported 2011-02-16 09:02:18 PST

We should be able to handle everything in webcore. First patch makes everything work in WebCore, second will remove WebKit code.

Attachments
Patch (12.93 KB, patch) 2011-02-16 09:57 PST, Pavel Feldman	no flags	Details Formatted Diff Diff
Patch (12.97 KB, patch) 2011-02-16 10:03 PST, Pavel Feldman	pfeldman: review-	Details Formatted Diff Diff
[PATCH] For bots (75.66 KB, patch) 2011-02-16 10:45 PST, Pavel Feldman	no flags	Details Formatted Diff Diff
Patch (40.90 KB, patch) 2011-05-31 13:55 PDT, Vsevolod Vlasov	simon.fraser: review- gustavo.noronha: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2011-02-16 09:57:00 PST

Created attachment 82655 [details] Patch

Pavel Feldman

Comment 2 2011-02-16 10:03:04 PST

Created attachment 82658 [details] Patch

Pavel Feldman

Comment 3 2011-02-16 10:45:01 PST

Created attachment 82662 [details] [PATCH] For bots

Early Warning System Bot

Comment 4 2011-02-16 11:05:32 PST

Attachment 82662 [details] did not build on qt: Build output: http://queues.webkit.org/results/7920378

Build Bot

Comment 5 2011-02-16 11:13:13 PST

Attachment 82662 [details] did not build on win: Build output: http://queues.webkit.org/results/7918376

Pavel Feldman

Comment 6 2011-02-16 11:24:30 PST

Comment on attachment 82658 [details] Patch Ok, so I now have a better understanding of why it was done in WebKit: compositing. James R. hinted that we could try introducing a separate layer on top of the world with the highlight. I'll look into it tomorrow. It should be all WebCore (rendering/ and platform/graphics/*).

Vsevolod Vlasov

Comment 7 2011-05-31 13:55:09 PDT

Created attachment 95477 [details] Patch

Vsevolod Vlasov

Comment 8 2011-05-31 13:57:58 PDT

This is a first attempt. I'd like to get some high level review on the approach. Also for some reason this doesn't work on mac non-WK2, whenever I try to highlight something in composited mode - highlight works fine, but all transformed layers disappear. I did not made anything about WK2 yet. see also: https://bugs.webkit.org/show_bug.cgi?id=54618

Collabora GTK+ EWS bot

Comment 9 2011-05-31 17:52:36 PDT

Comment on attachment 95477 [details] Patch Attachment 95477 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/8751808

Simon Fraser (smfr)

Comment 10 2011-06-06 07:56:53 PDT

Comment on attachment 95477 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95477&action=review > Source/WebCore/rendering/RenderLayerCompositor.cpp:1474 > + } else if (graphicsLayer == m_overlayLayer) > + m_renderView->frameView()->frame()->page()->pageOverlay()->paintComposited(context); This is just too convoluted. RLC shouldn't have to know anything about page()->pageOverlay(). I still think that the overlay layer should be hooked up outside of WebCore, just like WK2 does it.

Pavel Feldman

Comment 11 2011-08-08 22:47:26 PDT

As per comment #10

Note You need to log in before you can comment on or make changes to this bug.