Bug 54557

Summary: [GTK] libsoup critical warnings
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, svillar, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
proposed patch
none
proposed patch mrobinson: review+

Philippe Normand
Reported 2011-02-16 08:08:30 PST
Happens when using the Flash plugin for instance: libsoup-CRITICAL **: soup_message_io_pause: assertion `io != NULL' failed seems like it's trying to pause a message for an already downloaded ressource. Patch incoming
Attachments
proposed patch (1.94 KB, patch)
2011-02-16 08:11 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
proposed patch (1.93 KB, patch)
2011-02-16 08:54 PST, Philippe Normand 		mrobinson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2011-02-16 08:11:17 PST
Created attachment 82639 [details] proposed patch
Martin Robinson
Comment 2 2011-02-16 08:35:25 PST
Comment on attachment 82639 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=82639&action=review > Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:703 > + SoupMessage* soupMessage = d->m_soupMessage.get(); > + if (SOUP_STATUS_IS_SUCCESSFUL(soupMessage->status_code)) > + return; Hrm. Wouuld it be better to check for soupMessage->status_code != SOUP_STATUS_NONE? We don't want to cancel the message if it's finished for any reason.
Philippe Normand
Comment 3 2011-02-16 08:54:20 PST
Created attachment 82648 [details] proposed patch
Philippe Normand
Comment 4 2011-02-17 00:26:06 PST
Committed r78798: <http://trac.webkit.org/changeset/78798>
WebKit Review Bot
Comment 5 2011-02-17 03:47:22 PST
http://trac.webkit.org/changeset/78798 might have broken GTK Linux 32-bit Debug
Note You need to log in before you can comment on or make changes to this bug.