Bug 5449

Summary:

OBJECT should be accessible by id/name as document property only if its only children are PARAMs

Product:

WebKit

Reporter:

mitz

Component:

DOM

Assignee:

Dave Hyatt <hyatt>

Status:

VERIFIED FIXED

Severity:

Normal

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
testcase	none
Approximate IE's behavior	darin: review+

mitz

Reported 2005-10-21 02:15:10 PDT

(Separated from bug 5432) Object elements with a name or id are accessible as special properties of the document object (document ['objectname'] or document['objectid']). To better match IE's behavior, an object element should be a document property only when it has no children other than param elements.

Attachments
testcase (2.79 KB, text/html) 2005-10-21 02:20 PDT, mitz	no flags	Details
Approximate IE's behavior (6.29 KB, patch) 2005-10-21 02:22 PDT, mitz	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

mitz

Comment 1 2005-10-21 02:20:06 PDT

Created attachment 4434 [details] testcase

mitz

Comment 2 2005-10-21 02:22:19 PDT

Created attachment 4435 [details] Approximate IE's behavior IE doesn't allow HTML comments inside the object and this patch allows them (since they're not in the DOM tree).

Darin Adler

Comment 3 2005-10-22 08:48:54 PDT

Comment on attachment 4435 [details] Approximate IE's behavior Looks good. I'd like to see one comment in HTMLObjectElementImpl::updateDocNamedItem() saying that the rule is "<object> elements with no children other than <param> elements and whitespace can be found by name in a document, and other <object> elements cannot" But the code looks perfect to me.

David Harrison

Comment 4 2005-10-24 14:42:45 PDT

Committed. Added test as fast/js/object-by-name-or-id.html

Note You need to log in before you can comment on or make changes to this bug.