Bug 54485 – Fix spelling of -inProgramaticScroll

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[David Kilzer (:ddkilzer)]

Created attachment 82497 [details]
Patch

Reviewed by NOBODY (OOPS!).

* WebView/WebDynamicScrollBarsView.h:
* WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView inProgrammaticScroll]): Renamed from
-inProgramaticScroll.
* WebView/WebHTMLView.mm:
(-[WebHTMLView _frameOrBoundsChanged]): Corrected method name.
---
 4 files changed, 16 insertions(+), 3 deletions(-)

[Darin Adler]

Comment on attachment 82497 [details]
Patch

What about callers outside WebKit?

[David Kilzer (:ddkilzer)]

(In reply to comment #1)
> (From update of attachment 82497 [details])
> What about callers outside WebKit?

Safari doesn't use it.  I suspect -inProgramaticScroll should have gone in WebDynamicScrollBarsViewInternal.h anyway.

Note that this was added in r72852 for Bug 23556.

<http://trac.webkit.org/changeset/72852>

[Darin Adler]

(In reply to comment #2)
> I suspect -inProgramaticScroll should have gone in WebDynamicScrollBarsViewInternal.h anyway.

OK, we should fix that. We could do other research to make sure nothing at Apple is using it, but maybe there hasn’t been time.

[David Kilzer (:ddkilzer)]

Committed r78627: <http://trac.webkit.org/changeset/78627>

[David Kilzer (:ddkilzer)]

(In reply to comment #3)
> (In reply to comment #2)
> > I suspect -inProgramaticScroll should have gone in WebDynamicScrollBarsViewInternal.h anyway.
> 
> OK, we should fix that. We could do other research to make sure nothing at Apple is using it, but maybe there hasn’t been time.

I filed Bug 54505 about moving it.