Bug 54449

Summary: notImplemented() should behave identical in WebCore and WebKit2
Product: WebKit Reporter: Balazs Kelemen <kbalazs>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, darin, sam
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 54941    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Balazs Kelemen
Reported 2011-02-15 04:58:14 PST
The main benefit (besides consistency) of this would be the possibility to turn on warnings by default but turn off on bots not to break layout tests.
Attachments
Patch (43.63 KB, patch)
2011-02-15 08:38 PST, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
Patch (48.82 KB, patch)
2011-02-22 08:34 PST, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Balazs Kelemen
Comment 1 2011-02-15 08:38:32 PST
Created attachment 82462 [details] Patch
Darin Adler
Comment 2 2011-02-15 10:15:38 PST
Anders, Sam, since you added the WebKit2 version, you are the ones who should probably comment on whether this change is OK.
Anders Carlsson
Comment 3 2011-02-16 08:19:16 PST
Comment on attachment 82462 [details] Patch Sounds good to me. We just need to make sure that the warnings stay off by default.
Balazs Kelemen
Comment 4 2011-02-22 08:34:09 PST
Created attachment 83321 [details] Patch
Balazs Kelemen
Comment 5 2011-02-22 08:35:27 PST
Needed some change to fixing the Mac build.
Balazs Kelemen
Comment 6 2011-02-22 10:43:59 PST
Comment on attachment 83321 [details] Patch Need to be landed manually.
Balazs Kelemen
Comment 7 2011-02-22 10:46:13 PST
(In reply to comment #6) > (From update of attachment 83321 [details]) > Need to be landed manually. I mean since the last patch got r+ and the new one is just a build-fixed version of that I am going to land it manually.
Note You need to log in before you can comment on or make changes to this bug.