Bug 54435

Summary: Simplify CSSStyleSelector::canShareStyleWithElement
Product: WebKit Reporter: Roland Steiner <rolandsteiner>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement    
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch tkent: review+

Roland Steiner
Reported 2011-02-14 22:32:11 PST
CSSStyleSelector::canShareStyleWithElement() contains unneeded nesting and temporary variables that can be simplified and made more readable.
Attachments
Patch (9.67 KB, patch)
2011-02-14 22:40 PST, Roland Steiner 		tkent: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Roland Steiner
Comment 1 2011-02-14 22:40:10 PST
Created attachment 82417 [details] Patch
Kent Tamura
Comment 2 2011-02-14 23:12:54 PST
Comment on attachment 82417 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82417&action=review > Source/WebCore/css/CSSStyleSelector.cpp:1104 > + StyledElement* s = static_cast<StyledElement*>(n); "s" and "n" are not good variable names.
Roland Steiner
Comment 3 2011-02-22 00:24:16 PST
Committed r79298: <http://trac.webkit.org/changeset/79298>
Note You need to log in before you can comment on or make changes to this bug.