Summary: | nrwt multiprocessing: fix various windows-related regressions | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dirk Pranke <dpranke> | ||||
Component: | New Bugs | Assignee: | Dirk Pranke <dpranke> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aroben, eric, mihaip, ojan, tony | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Dirk Pranke
2011-02-14 20:34:17 PST
Created attachment 82412 [details]
Patch
I am open to better suggestions if anyone has some ... Comment on attachment 82412 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82412&action=review Seems fine to try. > Tools/Scripts/new-run-webkit-tests:40 > + # (which means a file in sys.path that ends in .py). We use the main > + # file in the layout_tests subdirectory, and we also make sure that > + # sys.path / PYTHONPATH is set and propagating correctly. Nit: The second sentence seems to be repeating what is already stated in the first sentence. > Tools/Scripts/new-run-webkit-tests:43 > + script_dir = os.path.dirname(os.path.abspath(__file__)) > + env = os.environ > + env['PYTHONPATH'] = script_dir Should we append the old PYTHONPATH to script_dir? > Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:47 > +# In order to reliably control when child workers are starting and stopping, > +# we a pair of global variables to hold queues used for messaging. Ideally Nit: we a pair -> we use a pair? > Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:51 > Nit: Remove blank line between comment and variables. Committed r78601: <http://trac.webkit.org/changeset/78601> (In reply to comment #3) > > Tools/Scripts/new-run-webkit-tests:40 > > + # (which means a file in sys.path that ends in .py). We use the main > > + # file in the layout_tests subdirectory, and we also make sure that > > + # sys.path / PYTHONPATH is set and propagating correctly. > > Nit: The second sentence seems to be repeating what is already stated in the first sentence. > The intent was to be slightly different, but it probably wasn't different enough to be worth it. removed. > > Tools/Scripts/new-run-webkit-tests:43 > > + script_dir = os.path.dirname(os.path.abspath(__file__)) > > + env = os.environ > > + env['PYTHONPATH'] = script_dir > > Should we append the old PYTHONPATH to script_dir? > Done. > > Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:47 > > +# In order to reliably control when child workers are starting and stopping, > > +# we a pair of global variables to hold queues used for messaging. Ideally > > Nit: we a pair -> we use a pair? > Fixed. > > Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:51 > > > > Nit: Remove blank line between comment and variables. Fixed. |