Summary: | DrawingAreaImpl::display handles error cases poorly | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||
Component: | Layout and Rendering | Assignee: | Adam Roben (:aroben) <aroben> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Adam Roben (:aroben)
2011-02-14 09:43:09 PST
Created attachment 82326 [details]
Patch
Comment on attachment 82326 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82326&action=review > Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:410 > + if (m_layerTreeHost) > + return; This might need a “why” comment. Comment on attachment 82326 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82326&action=review > Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:409 > + if (m_layerTreeHost) Please add a comment here, something like "we entered compositing mode" so we shouldn't paint. Comment on attachment 82326 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82326&action=review >> Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:410 >> + return; > > This might need a “why” comment. Added this comment: // The layout may have put the page into accelerated compositing mode, in which case the // LayerTreeHost is now in charge of displaying. Committed r78489: <http://trac.webkit.org/changeset/78489> |