Bug 54377

Summary: Clean up RenderTextControlSingleLine::createSubtreeIfNeeded()
Product: WebKit Reporter: Roland Steiner <rolandsteiner>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, dominicc, morrita, tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
extended patch none

Roland Steiner
Reported 2011-02-13 23:42:05 PST
RenderTextControlSingleLine::createSubtreeIfNeeded() is hard to read and contains a few superfluous conditions. Cleaning it up would help with further refactoring towards shadow DOM.
Attachments
Patch (5.70 KB, patch)
2011-02-13 23:48 PST, Roland Steiner 		no flags
DetailsFormatted DiffDiff
extended patch (6.39 KB, patch)
2011-02-14 00:14 PST, Roland Steiner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Roland Steiner
Comment 1 2011-02-13 23:48:17 PST
Created attachment 82290 [details] Patch
Kent Tamura
Comment 2 2011-02-13 23:51:58 PST
Comment on attachment 82290 [details] Patch looks good.
Roland Steiner
Comment 3 2011-02-14 00:14:00 PST
Created attachment 82292 [details] extended patch Extended patch, also removes superfluous check in createInnerBlockStyle() - inner blocks are only created for search fields, and those can never have spin buttons
WebKit Commit Bot
Comment 4 2011-02-14 06:09:07 PST
Comment on attachment 82292 [details] extended patch Clearing flags on attachment: 82292 Committed r78473: <http://trac.webkit.org/changeset/78473>
WebKit Commit Bot
Comment 5 2011-02-14 06:09:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.