Bug 54261

Summary: animation-play-state busted on nightlies
Product: WebKit Reporter: Dean Jackson <dino>
Component: CSSAssignee: Chris Marrin <cmarrin>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: dino, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
Attachments:
Description Flags
test case none

Dean Jackson
Reported 2011-02-10 17:43:41 PST
Changing animation play state is doing nothing in nightly builds. Works fine in latest Safari. See test case. How did our tests not pick this up?
Attachments
test case (1.01 KB, text/html)
2011-02-10 17:44 PST, Dean Jackson 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2011-02-10 17:44:04 PST
Created attachment 82078 [details] test case
Chris Marrin
Comment 2 2011-02-10 18:16:25 PST
(In reply to comment #0) > Changing animation play state is doing nothing in nightly builds. Works fine in latest Safari. > See test case. > > How did our tests not pick this up? If you look, the color animation does stop. It's only hardware animations that continue to run. This was fixed by http://trac.webkit.org/changeset/78051. I broke animations getting paused in the new PlatformCAAnimation code in Mac. The problem with testing is that, as far as the animation controller and the style logic is concerned the animation is stopped. It's just CA this isn't wise to this fact and we don't have any way to query what CA is doing.
Simon Fraser (smfr)
Comment 3 2011-02-10 19:01:35 PST
A carefully crafted pixel test would catch this.
Dean Jackson
Comment 4 2011-02-10 20:25:24 PST
So I guess this simply hasn't made it into nightlies. Marking as NMFP. *** This bug has been marked as a duplicate of bug 53513 ***
Note You need to log in before you can comment on or make changes to this bug.