Summary: | HTML5 <details> and <summary>: localized text | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Luiz Agostini <luiz> | ||||
Component: | Text | Assignee: | Luiz Agostini <luiz> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | Keywords: | HTML5 | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 51071 | ||||||
Attachments: |
|
Description
Luiz Agostini
2011-02-10 17:27:18 PST
Created attachment 82083 [details]
patch
Comment on attachment 82083 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=82083&action=review You should also run Tools/Scripts/update-webkit-localizable-strings to update the Localizable.strings file used by the Mac and Windows ports. > Source/WebCore/ChangeLog:9 > + The method summaryDefaultLabel was added to LocalizationStrategy class and to > + platform/LocalizedStrings. It is used to provide the default label to be used by a The name "summaryDefaultLabel" to me sounds like it is "the default label used for a <summary> element". Clearly that is wrong. I also think that "label" is mostly (only?) used to refer to the text inside (or associated with) a button. So maybe "defaultDetailsSummaryText" would be clearer? > Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.h:61 > virtual String fileButtonNoFileSelectedLabel(); > + virtual WTF::String summaryDefaultLabel(); Please omit "WTF::" here to match the other functions. Committed r78842: <http://trac.webkit.org/changeset/78842> |