Bug 54254

Summary: webkit2 pages gobble up cmd-I as an editing command in some cases where it shouldn't
Product: WebKit Reporter: Alice Liu <alice.barraclough>
Component: HTML EditingAssignee: Alice Liu <alice.barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: darin
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch adele: review+

Alice Liu
Reported 2011-02-10 15:54:29 PST
In WebKit, [WebHTMLView _handleStyleKeyEquivalent] returned early if [WebHTMLView _canEdit] was false. We're missing this early return case in WebKit2, in [WKView _handleStyleKeyEquivalent] [WebHTMLView _canEdit] boils down to checking if the current selection is in an editable region. <rdar://problem/8980859>
Attachments
patch (1.20 KB, patch)
2011-02-10 15:57 PST, Alice Liu 		adele: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alice Liu
Comment 1 2011-02-10 15:57:25 PST
Created attachment 82065 [details] patch
Enrica Casucci
Comment 2 2011-02-10 16:00:43 PST
Comment on attachment 82065 [details] patch Looks good to me.
Darin Adler
Comment 3 2011-02-10 18:06:45 PST
Comment on attachment 82065 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=82065&action=review > Source/WebKit2/UIProcess/API/mac/WKView.mm:992 > + if (!_data->_page->selectionState().isContentEditable) I think that longer term we might want this only if content is “richly” editable. No reason to enable these inside, say, an <input type=text>.
Darin Adler
Comment 4 2011-06-18 12:41:18 PDT
http://trac.webkit.org/changeset/78288
Note You need to log in before you can comment on or make changes to this bug.