Bug 54242

Summary: [Qt] Ensure WebView press delay timer is cancelled when grab is taken
Product: WebKit Reporter: Ademar Reis <ademar>
Component: WebKit QtAssignee: Ademar Reis <ademar>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kling, laszlo.gombos, webkit.review.bot
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
patch none

Description Ademar Reis 2011-02-10 13:44:50 PST 
See http://bugreports.qt.nokia.com/browse/QTBUG-15529 for a working test case.

"""
    Flickable steals the grab, but the timer was not stopped and the
    keepGrab flag is set and the mouse grabbed. This means that the WebView
    now has the grab and subsequent clicks on another element are ignored.
"""

Patch for webkit (based on the patch already submited to Qt) is on the way.
Comment 1 Ademar Reis 2011-02-10 13:48:18 PST 
Created attachment 82041 [details]
patch
Comment 2 WebKit Review Bot 2011-02-10 13:51:39 PST 
Attachment 82041 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/qt/ChangeLog', u'Source/WebK..." exit_code: 1

Source/WebKit/qt/declarative/qdeclarativewebview_p.h:73:  The parameter name "event" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2011-02-10 14:32:19 PST 
Comment on attachment 82041 [details]
patch

Clearing flags on attachment: 82041

Committed r78270: <http://trac.webkit.org/changeset/78270>
Comment 4 WebKit Commit Bot 2011-02-10 14:32:23 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Ademar Reis 2011-02-14 12:08:18 PST 
Revision r78270 cherry-picked into qtwebkit-2.1 with commit 830d494 <http://gitorious.org/webkit/qtwebkit/commit/830d494>
Comment 6 Ademar Reis 2011-02-17 06:21:04 PST 
Revision r78270 cherry-picked into qtwebkit-2.0 with commit dc72f20 <http://gitorious.org/webkit/qtwebkit/commit/dc72f20>