Bug 54241

Summary:

Enable ancestor identifier filtering for tree building

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

peter

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
patch	hyatt: review+

Antti Koivisto

Reported 2011-02-10 13:40:14 PST

This style selector optimization is currently enable during style recalc only. It should also be enabled for tree building.

Attachments
patch (8.04 KB, patch) 2011-02-10 14:30 PST, Antti Koivisto	hyatt: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2011-02-10 14:30:26 PST

Created attachment 82048 [details] patch Call CSSStyleSelector::push/popParent() during tree building too, fix up the parent element stack as needed. This roughly halves the remaining time in style matching over a typical page load.

Dave Hyatt

Comment 2 2011-02-10 14:51:55 PST

Comment on attachment 82048 [details] patch r=me. Run layout tests and make sure it's all still ok.

Antti Koivisto

Comment 3 2011-02-11 01:00:58 PST

http://trac.webkit.org/changeset/78322

Note You need to log in before you can comment on or make changes to this bug.