Bug 54190 – Fix ignore return warning in OSRandomSource.cpp

• Component: JavaScriptCore
• Status: RESOLVED DUPLICATE

[Peter Varga]

I got this warning with gcc-4.4.5:

cc1plus: warnings being treated as errors
../../../Source/JavaScriptCore/wtf/OSRandomSource.cpp: In function 'void WTF::randomValuesFromOS(unsigned char*, size_t)':
../../../Source/JavaScriptCore/wtf/OSRandomSource.cpp:53: error: ignoring return value of 'ssize_t read(int, void*, size_t)', declared with attribute warn_unused_result

[Peter Varga]

Created attachment 81948 [details]
proposed patch

[Csaba Osztrogonác]

Comment on attachment 81948 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=81948&action=review

> Source/JavaScriptCore/wtf/OSRandomSource.cpp:54
>      if (fd < 0)
>          CRASH(); // We need /dev/urandom for this API to work...
>  
> -    read(fd, buffer, length);
> -    close(fd);
> +    if (read(fd, buffer, length))
> +        close(fd);

read returns 0 at the end of file and -1 on errors.
The return value should be length. If an error occures,
we should crash instead of using uninitialized buffer.

if (read(fd, buffer, length) == length)
  close(fd);
else
  CRASH();

[Peter Varga]

Created attachment 81950 [details]
proposed patch v2

[WebKit Commit Bot]

Comment on attachment 81950 [details]
proposed patch v2

Rejecting attachment 81950 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-..." exit_code: 2

Last 500 characters of output:
ts/svn-apply', u'--reviewer', u'Csaba Osztrogon\xe1c',..." exit_code: 1

Parsed 2 diffs from patch file(s).
patching file Source/JavaScriptCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/JavaScriptCore/wtf/OSRandomSource.cpp
Hunk #1 FAILED at 50.
1 out of 1 hunk FAILED -- saving rejects to file Source/JavaScriptCore/wtf/OSRandomSource.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Csaba Osztrogon\xe1c',..." exit_code: 1

Full output: http://queues.webkit.org/results/7886288

[Csaba Osztrogonác]

CQ can't apply your patch because of http://trac.webkit.org/changeset/78195
Could you land it manually?

[Csaba Osztrogonác]

*** This bug has been marked as a duplicate of bug 54167 ***