Bug 54165

Summary: save overall comments when saving drafts in the review tool
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
abarth: review+
saved state
none
saving state
none
no modified comments state none

Ojan Vafai
Reported 2011-02-09 21:45:38 PST
save overall comments when saving drafts in the review tool
Attachments
Patch (7.80 KB, patch)
2011-02-09 21:48 PST, Ojan Vafai 		abarth: review+
DetailsFormatted DiffDiff
saved state (12.98 KB, image/png)
2011-02-09 21:51 PST, Ojan Vafai 		no flags
Details
saving state (9.66 KB, image/png)
2011-02-09 21:51 PST, Ojan Vafai 		no flags
Details
no modified comments state (8.79 KB, image/png)
2011-02-09 21:52 PST, Ojan Vafai 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2011-02-09 21:48:29 PST
Created attachment 81919 [details] Patch
Ojan Vafai
Comment 2 2011-02-09 21:48:45 PST
*** Bug 54121 has been marked as a duplicate of this bug. ***
Ojan Vafai
Comment 3 2011-02-09 21:51:03 PST
Created attachment 81920 [details] saved state
Ojan Vafai
Comment 4 2011-02-09 21:51:24 PST
Created attachment 81921 [details] saving state
Ojan Vafai
Comment 5 2011-02-09 21:52:01 PST
Created attachment 81922 [details] no modified comments state
Adam Barth
Comment 6 2011-02-10 01:28:42 PST
Comment on attachment 81919 [details] Patch Cool. My only worry is if the saving indicator is annoying. :) Now I'll noodle you about one bug. When you expand context (at least in unified mode) the expanded text is indented an extra character.
Ojan Vafai
Comment 7 2011-02-10 16:13:46 PST
(In reply to comment #6) > (From update of attachment 81919 [details]) > Cool. My only worry is if the saving indicator is annoying. :) Yeah. I had the same worry. I'm pretty happy with the end result though. If it bothers people we can always tweak/remove it. > Now I'll noodle you about one bug. When you expand context (at least in unified mode) the expanded text is indented an extra character. I'll take a look.
Ojan Vafai
Comment 8 2011-02-10 16:14:57 PST
Committed r78283: <http://trac.webkit.org/changeset/78283>
Note You need to log in before you can comment on or make changes to this bug.