Bug 54164

Summary: Optimize global_var accesses on JSVALUE64
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
The patch sam: review+

Gavin Barraclough
Reported 2011-02-09 20:45:54 PST
Directly embed the pointer to d->registers, ptimize out the load from the variable object, as we do already in JSVALUE32_64. This is a ~1.5% win on sunspidey.
Attachments
The patch (5.18 KB, patch)
2011-02-09 20:47 PST, Gavin Barraclough 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2011-02-09 20:47:46 PST
Created attachment 81917 [details] The patch
Sam Weinig
Comment 2 2011-02-09 20:50:25 PST
Comment on attachment 81917 [details] The patch View in context: https://bugs.webkit.org/attachment.cgi?id=81917&action=review > Source/JavaScriptCore/ChangeLog:7 > + Directly embed the pointer to d->registers, ptimize out the load ptimize -> optimize. I am glad to see you are even optimizing spelling! > Source/JavaScriptCore/ChangeLog:10 > + This is a ~1.5% win on sunspidey. Wow, nice.
Gavin Barraclough
Comment 3 2011-02-09 21:22:18 PST
Fixed in r78174
Note You need to log in before you can comment on or make changes to this bug.