Bug 54154

Summary: File uploads do not work within the sandbox
Product: WebKit Reporter: Sam Weinig <sam>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Patch darin: review+

Sam Weinig
Reported 2011-02-09 16:55:34 PST
File uploads do not work within the sandbox
Attachments
Patch (3.80 KB, patch)
2011-02-09 16:57 PST, Sam Weinig 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2011-02-09 16:57:49 PST
Created attachment 81895 [details] Patch
Darin Adler
Comment 2 2011-02-09 17:00:51 PST
Comment on attachment 81895 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=81895&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:2124 > + SandboxExtension::Handle sandboxExtensionHandle; > + SandboxExtension::createHandle(fileURLs[i], SandboxExtension::ReadOnly, sandboxExtensionHandle); Why does this use an out argument instead of a return value? > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1561 > + RefPtr<SandboxExtension> extension = SandboxExtension::create(handle); > + extension->consumePermanently(); No need for a local variable here.
Sam Weinig
Comment 3 2011-02-09 17:18:18 PST
Fixed in http://trac.webkit.org/changeset/78163.
Note You need to log in before you can comment on or make changes to this bug.