| Summary: | Replace static_cast<HTMLElement*> with toHTMLElement | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yael <yael> | ||||||
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, commit-queue, darin, eric, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
|
Description
Yael
2011-02-09 10:20:40 PST
Created attachment 81829 [details]
Patch.
Comment on attachment 81829 [details]
Patch.
Did you run all the regression tests? Did any assertions fire?
(In reply to comment #2) > (From update of attachment 81829 [details]) > Did you run all the regression tests? Did any assertions fire? The tests are still running, but I just noticed a crash. I'll stop the commit queue, it will fail anyways. Created attachment 81851 [details]
Patch.
Only one test hit the ASSERT. It is editing/execCommand/insert-list-nested-with-orphaned.html .
This test is really expecting the function enclosingListChild to return a node which is not an HTMLElement.
(The test fails if I skip nodes that are not HTMLElements.)
Once I modified enclosingListChild to return Node and not HTMLElement, all tests are passing. I updated the patch to return a Node from enclosingListChild.
(In reply to comment #4) > This test is really expecting the function enclosingListChild to return a node which is not an HTMLElement. Is it an Element? Element* would be better than Node*. (In reply to comment #5) > (In reply to comment #4) > > This test is really expecting the function enclosingListChild to return a node which is not an HTMLElement. > > Is it an Element? Element* would be better than Node*. This is a text node, not an element. It asserts when I use toElement(). Comment on attachment 81851 [details] Patch. Clearing flags on attachment: 81851 Committed r78150: <http://trac.webkit.org/changeset/78150> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/78150 might have broken Qt Windows 32-bit Release |