Bug 54113
| Summary: | Review tool should not force various style/build bot links to load in the current window | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Oliver Hunt <oliver> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | abarth, ahmad.saleem792, ap, bfulgham, ryanhaddad |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
Oliver Hunt
I frequently want to look at bot output while reviewing a patch, but the forced in place navigation means that i cannot maintain context, and will lose incomplete comments.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adam Barth
I think the problem is that we're using click handlers instead of hyperlinks.
Adam Barth
Notice the onclick handler here:
http://trac.webkit.org/browser/trunk/Tools/QueueStatusServer/templates/statusbubble.html
We just need to change that to an anchor element and adjust the CSS to keep it looking pretty.
Ahmad Saleem
Do we need this and now Status Bubbles are managed on GitHub? Is this still exist? Thanks!
Alexey Proskuryakov
This is working as expected in Bugzilla too now.