Summary: | [NRWT] Remove encoding parameters in rebaseline. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hayato Ito <hayato> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dpranke, eric, ojan, tony | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Hayato Ito
2011-02-08 22:15:09 PST
Created attachment 81752 [details]
remove-encoding-parameters
Comment on attachment 81752 [details]
remove-encoding-parameters
Thanks!
As long as nothing breaks, I guess this change is fine, but I still feel kind of uncomfortable about it. Perhaps we should also change the expected_text() and expected_checksum() methods in port/base.py to use read_binary_file() instead of read_text_file()? (In reply to comment #3) > As long as nothing breaks, I guess this change is fine, but I still feel kind of uncomfortable about it. Perhaps we should also change the expected_text() and expected_checksum() methods in port/base.py to use read_binary_file() instead of read_text_file()? expected_text() already uses read_binary_file(). expected_checksum() could use either since it's just reading ascii. It's probably a bit safer to use read_text_file(), but I don't feel strongly one way or another. (In reply to comment #4) > (In reply to comment #3) > > As long as nothing breaks, I guess this change is fine, but I still feel kind of uncomfortable about it. Perhaps we should also change the expected_text() and expected_checksum() methods in port/base.py to use read_binary_file() instead of read_text_file()? > > expected_text() already uses read_binary_file(). expected_checksum() could use either since it's just reading ascii. It's probably a bit safer to use read_text_file(), but I don't feel strongly one way or another. You're right. Apparently I can't read. Anyway, I would feel better if we changed expected_checksum() to use read_binary_file() as well, for consistency. Thank you for the reviews. I'll commit the patch after I change expected_checksum() to use read_binary_file(). (In reply to comment #5) > You're right. Apparently I can't read. Anyway, I would feel better if we changed expected_checksum() to use read_binary_file() as well, for consistency. Committed r78175: <http://trac.webkit.org/changeset/78175> |