Summary: | -webkit-font-smoothing:antialiased has no effect on GDI text | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||
Component: | Text | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | adele, mitz, roger_fong, thorton, webkit.review.bot | ||||
Priority: | P2 | Keywords: | InRadar, PlatformOnly | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
URL: | data:text/html,<p style="-webkit-font-smoothing:antialiased">This text should not be subpixel-antialiased.</p><p>This text should be subpixel-antialiased.</p> | ||||||
Attachments: |
|
Description
Adam Roben (:aroben)
2011-02-08 07:56:30 PST
When specifying -webkit-font-smoothing: antialised; the code path ends up using GDI to draw the text. Firstly, this causes a lot of transparency issues since GDI has no concept of an alpha channel. Secondly, in the code path, GDI ends up drawing subpixel antialiased text, not aliased text anyways. The CG code path also has the capability of drawing antialiased text. The reason that the GDI path was used in the first place is no longer a concern here so we can stop using the GDI code path. I'll be getting rid of the GDI code path so that font rendering on windows only uses CG code path for font rendering, instead of sometimes using CG and sometimes using GDI. *** Bug 94958 has been marked as a duplicate of this bug. *** Created attachment 160460 [details]
patch
Comment on attachment 160460 [details] patch Rejecting attachment 160460 [details] from commit-queue. roger_fong@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. Comment on attachment 160460 [details] patch Clearing flags on attachment: 160460 Committed r126666: <http://trac.webkit.org/changeset/126666> All reviewed patches have been landed. Closing bug. |